Closed Bug 1696793 Opened 4 years ago Closed 4 years ago

Browser gets stuck in disabled state after cancelling modal dialog with Esc key while focus on background

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Firefox 88
Desktop
All

Tracking

(firefox-esr78 unaffected, firefox86 unaffected, firefox87 disabled, firefox88 verified)

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- disabled
firefox88 --- verified

People

(Reporter: ke5trel, Assigned: Gijs)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-modals])

Attachments

(1 file)

STR:

  1. Ensure prompts.windowPromptSubDialog = true.
  2. Press Ctrl+Q or Ctrl+Shift+Q with quit warning enabled.
  3. Modal dialog appears, click in the background disabled region of the window.
  4. Press Esc.

Expected:

Browser continues to operate normally after modal dialog dismissed.

Actual:

Modal dialog goes away but many things stop working, the new tab button is greyed out as well as many menu items. Cannot close window or quit, only apparent way to recover is to terminate the application.

The problem only occurs when the focus is in the background disabled region when the Esc key is pressed.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Notifications and Alerts' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Notifications and Alerts
Product: Firefox → Toolkit
Assignee: nobody → gijskruitbosch+bugs
Severity: -- → S2
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: -- → P1
Hardware: Unspecified → Desktop
Whiteboard: [proton-modals]

The html:dialog event can respond to [esc] keypresses itself. In that case,
we need to close the embedded dialog ourselves, or the UI ends up broken.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8bd015dd9182 fix window modal dialog handling of html:dialog closing separately, r=mtigley
Attachment #9207443 - Attachment description: Bug 1696793 - fix window modal dialog handling of html:dialog closing separately, r?mtigley → Bug 1696793 - improve close and multiple dialog handling for window-modal dialogs, r?mtigley
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f476c97b7c04 improve close and multiple dialog handling for window-modal dialogs, r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Blocks: 1698526
Regressions: 1698514

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit) . I followed the steps in ubuntu 20.04, win 10 pro , and mac0s 11.4 beta, and this issue is no longer reproducible
Updating status accordingly.
Best regards,
Clara

Has Regression Range: --- → yes
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: