1696793 - Browser gets stuck in disabled state after cancelling modal dialog with Esc key while focus on background

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[Kestrel]

STR:

1. Ensure prompts.windowPromptSubDialog = true.
2. Press Ctrl+Q or Ctrl+Shift+Q with quit warning enabled.
3. Modal dialog appears, click in the background disabled region of the window.
4. Press Esc.

Expected:

Browser continues to operate normally after modal dialog dismissed.

Actual:

Modal dialog goes away but many things stop working, the new tab button is greyed out as well as many menu items. Cannot close window or quit, only apparent way to recover is to terminate the application.

The problem only occurs when the focus is in the background disabled region when the Esc key is pressed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Notifications and Alerts' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1696793 - improve close and multiple dialog handling for window-modal dialogs, r?mtigley

The html:dialog event can respond to [esc] keypresses itself. In that case,
we need to close the embedded dialog ourselves, or the UI ends up broken.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bd015dd9182
fix window modal dialog handling of html:dialog closing separately, r=mtigley

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 8bd015dd9182 (Bug 1696793) for causing failures in browser_confirm_unblock_download.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=UUcpiKjaTuqCjMa3UH9Gng.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8bd015dd9182cc8d85c0627233a97c24b150c6db

Failure log: https://treeherder.mozilla.org/logviewer?job_id=332510456&repo=autoland&lineNumber=3098

Backout: https://hg.mozilla.org/integration/autoland/rev/275b8377ee60dacf59a809d4be92b2eade3402d9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f476c97b7c04
improve close and multiple dialog handling for window-modal dialogs, r=mtigley

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f476c97b7c04

Comment 7

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit) . I followed the steps in ubuntu 20.04, win 10 pro , and mac0s 11.4 beta, and this issue is no longer reproducible
Updating status accordingly.
Best regards,
Clara