1696907 - Make probe expiry alerts create bugs for expiring Glean Metrics in mozilla-central

Status: RESOLVED FIXED

(Data Platform and Tools :: General, enhancement, P1)

Description

[Chris H-C :chutten]

The "your probes are expiring, you'd better renew or remove" bug auto-filer has been working so smoothly these past 10 months, I'd forgotten that it didn't work for Glean Metrics in mozilla-central.

Which means Aryx needed to file bug 1696890 manually when we failed the version increase simulation.

Since probe expiry in mozilla-central is now a build failure, it is of high importance to reach data owners where they work so that we don't block version increase simulation builds with expired probes. This may mean filing bugs even earlier than before, and using somewhat stronger language (like "perma build failure").

Comment 1

[Chris H-C :chutten]

See also bug 1696916 for where we intend to make expired metrics into a test failure not a build failure. (Still a good idea to file bugs nice and early)

Comment 2

[Chris H-C :chutten]

Preliminary support for this landed in https://github.com/mozilla/probe-scraper/issues/276 but unfortunately is broken for two reasons

1. I didn't modify telemetry-airflow to hand the bugzilla API key to probe_scraper.runner (so no bugs would be filed)
2. It can't detect expiring metrics if it processes a repo without expiring metrics before a repo with expiring metrics (because this line is a return meaning that if it processes a repo without expiring metrics, it'll early-return even if it processes a repo with expired metrics in it. In this case there are no expiring metrics in gecko, but there are some in firefox-desktop. You can see this locally if you run a dry run like python -m probe_scraper.runner --glean --glean-repo glean-core --glean-repo glean-android --glean-repo gecko --glean-repo firefox-desktop --dry-run --cache-dir .scraper_cache/ )

Time to solve those problems.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/probe-scraper/pull/403

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/telemetry-airflow/pull/1466

Comment 5

[Chris H-C :chutten]

chutten merged PR #403: "bug 1696907 - Don't early-return if one FOG repo has no expiring metrics" in f8bf7ca.

Comment 6

[Chris H-C :chutten]

chutten merged PR #1466: "bug 1696907 - Give probe_scraper.runner a copy of the BMO API key" in 84329bd.

There, that should do it. We'll see what happens next Wednesday.