1610616 - Make probe expiry alerts create bugs for expiring probes

Status: RESOLVED FIXED

(Data Platform and Tools :: General, enhancement, P3)

Description

[Ben Wu [:benwu]]

This is an updated version of bug 1261400.

Probe expiry alerts currently sends weekly emails for expiring probes. It would be useful to file bugs for probes either instead of or alongside the emails and tag probe owners. Bugs may have better visibility and allow for tracking. Another advantage is that the existence of the bug can act as a state and we wouldn't need to send weekly emails which can get spammy.

We'll probably need to put a bugzilla api key into airflow for this.

Comment 1

[Ben Wu [:benwu]]

:ryanvm, are there any details we should be aware of to make this better align with the release cycle? I know that some bugs are manually filed in the version increase simulation if tests fail due to expired bugs so there will be duplicates. Is this ok to do? Any thoughts on how to best handle this?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I don't think it'd be a big deal if there were occasional duplicates filed. We probably just want to link them together in the end.

Comment 3

[Ben Wu [:benwu]]

I've thought about this a little more and I'm wondering if filing bugs the best thing to do. Should it be done instead of or in addition to emails? I figure it could be better for visibility since it's persistent and less spammy than weekly emails. But with bugzilla email filters and the fact that somewhat spammy might be what we want, I'm not sure this is needed. Implementation is fairly low effort so either way is fine with me. I think sending one email and filing bugs each time new expiring probes are found (each release cycle) would be a good balance.

The implementation I have will create bugs for any probe expiring the next version, probably with ni? for the probe owners. If a bug was previously created for a probe that is no longer expiring in the next version it will be marked as resolved on the next run (should we let owners close the bug themselves?).

Comment 4

[Chris H-C :chutten]

Bugs (like this one) and emails have both been used to alert people of expiring probes in the past. From what I can tell the bugs are responded to much better than emails, perhaps because by placing them in the correct component the Triage Owner then is motivated to deal with it.

I don't know that mail on top of the bugs will have any greater effect... but with the email able to bounce over bugmail filters, maybe it's worth it? I think the mails given for the needinfo? you propose will be as effective if not more, so long as the email content is reasonably-well translatable to a bug description.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/probe-scraper/commit/c84efa68a776bedc26aaa0f07d81a0a7c46c67dd

Commit merged into master by GitHub
Authored by Ben Wu (Ben-Wu)

Comment 7

[Ben Wu [:benwu]]

Bugs are now being created by https://github.com/mozilla/probe-scraper/pull/181

This search shows the created bugs:
https://bugzilla.mozilla.org/buglist.cgi?classification=Client%20Software&classification=Developer%20Infrastructure&classification=Components&classification=Server%20Software&classification=Other&list_id=15226110&status_whiteboard=%5Bprobe-expiry-alert%5D&resolution=---&query_format=advanced&status_whiteboard_type=allwordssubstr

I'll continue monitoring to make sure the bot doesn't go wild.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Had created https://github.com/mozilla/probe-scraper/issues/276 for bug 1696907 no.