Closed Bug 1697047 Opened 3 years ago Closed 2 years ago

Set dedicated "toolkit.asyncshutdown.crash_timeout" value for code coverage builds

Categories

(Testing :: Code Coverage, enhancement)

Default
enhancement

Tracking

(firefox106 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The default value for toolkit.asyncshutdown.crash_timeout is too short for CCOV builds (see bug 1692291 comment 13). As such it would be good to add a dedicated value similar to ASAN builds:

https://searchfox.org/mozilla-central/rev/002023eb262be9db3479142355e1675645d52d52/modules/libpref/init/all.js#792-802

No longer blocks: 1692291
Blocks: 1697382
Blocks: 1783217

Marco, which value could be used for CCOV builds? It would be great to get this special handling landed.

Flags: needinfo?(mcastelluccio)

I think we can start with the same value as ASAN (3 minutes), and then adjust if necessary.

Flags: needinfo?(mcastelluccio)

(In reply to Marco Castelluccio [:marco] from comment #2)

I think we can start with the same value as ASAN (3 minutes), and then adjust if necessary.

Please note that ASAN has actually 300000ms which are 5 minutes. But I'm happy to start with 3 minutes as you suggest here.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3046181b870f
Extend asyncshutdown crash timeout for CCOV builds to 3 minutes. r=marco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: