1697047 - Set dedicated "toolkit.asyncshutdown.crash_timeout" value for code coverage builds

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The default value for toolkit.asyncshutdown.crash_timeout is too short for CCOV builds (see bug 1692291 comment 13). As such it would be good to add a dedicated value similar to ASAN builds:

https://searchfox.org/mozilla-central/rev/002023eb262be9db3479142355e1675645d52d52/modules/libpref/init/all.js#792-802

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marco, which value could be used for CCOV builds? It would be great to get this special handling landed.

Comment 2

[Marco Castelluccio [:marco]]

I think we can start with the same value as ASAN (3 minutes), and then adjust if necessary.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Marco Castelluccio [:marco] from comment #2)

I think we can start with the same value as ASAN (3 minutes), and then adjust if necessary.

Please note that ASAN has actually 300000ms which are 5 minutes. But I'm happy to start with 3 minutes as you suggest here.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1697047 - Extend asyncshutdown crash timeout for CCOV builds to 3 minutes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3046181b870f
Extend asyncshutdown crash timeout for CCOV builds to 3 minutes. r=marco

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3046181b870f