1697382 - Improve quit / restart Marionette unit tests for slow running CCOV builds

Status: NEW

(Testing :: Marionette Client and Harness, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

+++ This bug was initially created as a clone of Bug #1692291 +++

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from bug 1692291 comment #7)

I think it would be fine to bump up the shutdown timeout for the test here:
https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_quit_restart.py#213

The problem right now with this test is that in case of a longer shutdown the test fails (as we can see) but doesn't let kick in the HangMonitor to kill the process, and produce a helpful crash report.

Together with the New Session command we actually get the moz:shutdownTimeout capability returned:

https://searchfox.org/mozilla-release/source/testing/marionette/capabilities.js#481-482

[task 2021-02-11T18:40:23.904Z] 18:40:23     INFO -  1613068823901	Marionette	DEBUG	2 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2021-02-11T18:40:23.912Z] 18:40:23     INFO -  1613068823906	Marionette	DEBUG	2 <- [1,1,null,{"sessionId":"53e298d9-8f0c-40bd-abff-055b607910a2","capabilities":{"browserName":"firefox","browserVersion":"87.0a ... mp/tmpZc69mT.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]

And since bug 1500242 we update the internal shutdown_timeout value:

https://searchfox.org/mozilla-central/rev/8d9564059dbc1e36fb9152e6b6227343d0b49662/testing/marionette/client/marionette_driver/marionette.py#1200-1203

I assume that for CCOV builds we have a dedicated value set for toolkit.asyncshutdown.crash_timeout?

As such I'm more inclined to completely remove the custom shutdown timeout in the test, and rely on the internal self.shutdown_timeout value if its not None.

A dedicated value will be added via bug 1697047.