1697053 - Let non-native theme ride to Beta and Release (in 89)

Status: RESOLVED FIXED

(Core :: Widget, task, P3)

Description

[Chris Peterson [:cpeterson]]

We currently plan to let non-native theme ride the trains in 89. We don't need to do anything for this in 88 Nightly or Beta (though the Fission team might enable non-native theme early for macOS users in a Fission Beta experiment in 88 Beta).

Comment 1

[Chris Peterson [:cpeterson]]

This bug no longer needs to block the Fission M7a Beta experiment. In bug 1697055, kmag enabled non-native theme for users in the Fission experiment.

Non-native theme will ship in 89, well before our Fission M8 Release experiment.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Please ni? me on bugs you actually want me to take, otherwise I might miss them :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1697053 - Let non-native-theme ride the trains in Firefox 89. r=cpeterson!,mstange!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

ni? for https://phabricator.services.mozilla.com/D109555#3559654. In particular, the reasoning is that if something would cause us to turn off nnt by default on release, we probably would also want to do that for fissuon users? But again I can leave the code if you want.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0820378114
Let non-native-theme ride the trains in Firefox 89. r=cpeterson,mstange

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

ni? for https://phabricator.services.mozilla.com/D109555#3559654. In particular, the reasoning is that if something would cause us to turn off nnt by default on release, we probably would also want to do that for fissuon users? But again I can leave the code if you want.

LGMT. No need to keep the special case for Fission.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cd0820378114

Comment 8

[Pascal Chevrel:pascalc]

Hi Emilio, does it require a mention in our 89 release notes? If it does, could you request it please? Is that on all platforms?
Thanks

Comment 9

[Chris Peterson [:cpeterson]]

@ Emilio, feel free to suggest any changes to my proposed wording below!

Release Note Request (optional, but appreciated)

[Why is this notable]: The non-native theme (for web form controls) will be visible to users. Also, it may cause webcompat issues if web pages make assumptions about the dimensions or styling of form controls.

[Suggested wording]: I think this feature is relevant for the release note's "New" section.

Introducing a non-native implementation of web form controls, which delivers a new modern design and some improvements to page load performance. Watch for layout bugs in web pages that make assumptions about the dimensions or styling of form controls.

[Links (documentation, blog post, etc)]: Not at this time. I'm talking with Proton PM about maybe mentioning non-native theme in a Proton UX blog post.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Sounds good, thanks Chris.

Comment 11

[Pascal Chevrel:pascalc]

Added to nightly release notes with the suggested wording, thanks

Comment 14

[Chris Peterson [:cpeterson]]

Pascal, the non-native theme is also relevant for Android's release notes for 89.0a1. Do I need to flag this bug in a special way to add the release note for both desktop and Android?

I see our release note on 89.0a1's Desktop Nightly release notes, but I don't see a page for Android Nightly's release notes:

https://www.mozilla.org/en-US/firefox/89.0a1/releasenotes/

btw, the Android Beta release notes are from the ancient Fennec 68.7beta and should probably be taken down:

https://www.mozilla.org/en-US/firefox/android/68.7beta/releasenotes/

Comment 15

[Pascal Chevrel:pascalc]

(In reply to Chris Peterson [:cpeterson] from comment #14)

Pascal, the non-native theme is also relevant for Android's release notes for 89.0a1. Do I need to flag this bug in a special way to add the release note for both desktop and Android?

I see our release note on 89.0a1's Desktop Nightly release notes, but I don't see a page for Android Nightly's release notes:

https://www.mozilla.org/en-US/firefox/89.0a1/releasenotes/

btw, the Android Beta release notes are from the ancient Fennec 68.7beta and should probably be taken down:

https://www.mozilla.org/en-US/firefox/android/68.7beta/releasenotes/

I am not sure who owns Android release notes these days, I'll investigate.

Comment 16

[Pascal Chevrel:pascalc]

This is in our 89 beta notes and should be in our final notes managed by our comms team.