1697325 - Refactor and clean up related to CSS overflow area handling

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

None of the patches in this bug should change the behavior.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697325 Part 1 - Rename VisualDeltas to InkOverflowDeltas.

Bug 1637130 renamed visual overflow to ink overflow to match the spec
terms. This is a follow-up to rename the struct that stores small ink
overflow in nsIFrame.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697325 Part 2 - Merge SetOverflowAreas() documentation in nsIFrame.cpp into nsIFrame.h.

Depends on D107735

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697325 Part 3 - Change NS_FRAME_OVERFLOW_DELTA_MAX to a constexpr in InkOverflowDeltas.

Depends on D107736

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697325 Part 4 - Change two overflow type #defines to values in an enum class, and revise documentation.

Depends on D107737

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697325 Part 5 - Add GetOverflowAreasRelativeToParent(), and simplify all the call sites.

Depends on D107738

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd611df1f0e1
Part 1 - Rename VisualDeltas to InkOverflowDeltas. r=emilio
https://hg.mozilla.org/integration/autoland/rev/00616de4b8a9
Part 2 - Merge SetOverflowAreas() documentation in nsIFrame.cpp into nsIFrame.h. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4c58a667455a
Part 3 - Change NS_FRAME_OVERFLOW_DELTA_MAX to a constexpr in InkOverflowDeltas. r=emilio
https://hg.mozilla.org/integration/autoland/rev/db3777803f74
Part 4 - Change two overflow type #defines to values in an enum class, and revise documentation. r=emilio
https://hg.mozilla.org/integration/autoland/rev/40587ee0a347
Part 5 - Add GetOverflowAreasRelativeToParent(), and simplify all the call sites. r=emilio

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fd611df1f0e1
https://hg.mozilla.org/mozilla-central/rev/00616de4b8a9
https://hg.mozilla.org/mozilla-central/rev/4c58a667455a
https://hg.mozilla.org/mozilla-central/rev/db3777803f74
https://hg.mozilla.org/mozilla-central/rev/40587ee0a347