1697349 - [css-flexbox] Include flex item's margins and flex container's padding in the flex container's overflow area

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, enhancement)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

+++ This bug was initially created as a clone of Bug #1527539 +++

I'd like to explore the implementation of flexbox in this bug, and the original bug 1527539 for grid.

We have existing tests overflow-area-001.html and overflow-area-002.html added by fantasai in https://github.com/web-platform-tests/wpt/pull/23445

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697349 Part 1 - Add some helper methods used in the next part.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1697349 - Incorporate flex item's margin and flex container's padding when computing flex container's overflow area.

This patch incorporates flex item's margin and flex container's padding
when computing flex container's overflow area in both the inline axis
and block axis.

flexbox_stf-table-singleline-2.html and overflow-top-left.html start
failing because both tests have flex items with margin contributing to
the overflow area now. I believe they test other browsers current
behavior, so I leave them untouched.

Depends on D107935

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Blink fixed their version of this bug in https://bugs.chromium.org/p/chromium/issues/detail?id=1069614, and is targeting M91 released on May 25, 2021. We are approaching soft freeze for 88, and our time frame for 89 (released on May 18, 20201) is similar to blink's M91. So let's land my patches after 89 cycle begins next week. NI myself as a reminder.

Comment 4

[Phabricator Automation]

Comment on attachment 9208259 [details]
Bug 1697349 Part 1 - Add some helper methods used in the next part.

Revision D107935 was moved to bug 1699327. Setting attachment 9208259 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94323c03b3da
Incorporate flex item's margin and flex container's padding when computing flex container's overflow area. r=dholbert

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28175 for changes under testing/web-platform/tests

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/94323c03b3da

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot