Closed Bug 1697449 Opened 4 years ago Closed 3 years ago

[macOS] Form Autofill Address doesn't work (for US)

Categories

(Toolkit :: Form Autofill, defect)

x86_64
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1717603
Tracking Status
firefox86 --- unaffected
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- fix-optional

People

(Reporter: cgeorgiu, Unassigned, NeedInfo)

Details

(Keywords: regression)

Affected versions

  • latest Nightly 88.0a1
  • Beta 87.0b8

Prerequisites

  • To activate the Form Autofill feature on a Beta build, go to about:config, search for the extensions.formautofill.available pref and modify it from "detect" to "on".

  • browser.search.region set to US

  • Go to browser Options, Privacy and Security section, Forms & Autofill section, click the "Saved Addresses..." button and add 1 or 2 address forms.

Affected platforms

  • macOS 10.15
  • mac 11

Steps to reproduce

  1. Navigate to https://luke-chang.github.io/autofill-demo/basic.html and double click on the Name field.

Expected result

  • A autofill dropdown is displayed showing the saved addresses (from profiles you have saved).

Actual result

  • The autofill drop down is not displayed.

Suggested Severity

  • S2, since this feature won't work for the US folks.

Regression range

  • This seems to be regression, I was not able to reproduce it on Release 86.0. I will provide a regression range asap.

Additional details

  • it seems that the issue is only reproducible on macOS
Summary: [macOS] Form Autofill Addresses doesn't work (for US) → [macOS] Form Autofill Address doesn't work (for US)
QA Whiteboard: [qa-regression-triage]
Has Regression Range: --- → no
Has STR: --- → yes

Can you please look for a regression range when you get a chance?

Flags: needinfo?(ciprian.georgiu)

I'm unable to reproduce this in 10.13. Tested in 86 release, 87 RC, and 88 Nightly. After filling in name, address, city, zip and email, I was able to autofill on the test case site mentioned below. This was with a US version of Firefox.

(In reply to Brian Grinstead [:bgrins] from comment #1)

Can you please look for a regression range when you get a chance?

It looks that mozregression found bug 1684760 as the regressor of this issue. I hope this helps.

build_date: 2021-01-03 16:51:03.992000
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/feNMc7MFRcmg_K3mds_iCg/runs/0/artifacts/public%2Fbuild%2Ftarget.dmg
changeset: eaa05f1555688194b8b32ef84dfb6571a539d82a
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eaa05f1555688194b8b32ef84dfb6571a539d82a&tochange=89fef9703703e6ca5427be85d477097aa2a09ba4

(In reply to Jim Mathies [:jimm] from comment #2)

I'm unable to reproduce this in 10.13. Tested in 86 release, 87 RC, and 88 Nightly. After filling in name, address, city, zip and email, I was able to autofill on the test case site mentioned below. This was with a US version of Firefox.

I think it may be somehow intermitted, I was unable to reproduce the issue as well on Nightly 88.0a1, but only after trying several times on different FF profiles.

I'm pasting the error I get in the browser console, each time I double click on one of the website's text fields.

TypeError: item._adjustAcItem is not a function autocomplete-popup.js:496:16 Invalid type for value parameter.

Let me know if there's anything else I can help with.

Flags: needinfo?(ciprian.georgiu)

Thanks for checking. Looking at Bug 1684760 it seems unrelated, so I'm guessing it's not actually a regressor but a result of this being intermittent and so really hard to bisect.

About the intermittency:

  1. Is it randomly happening across many profiles or does it consistently reproduce but only in a certain profile?
  2. The JS error helps - are you only seeing that when it doesn't work or are you seeing that even on profiles / STR where it doesn't reproduce?
Flags: needinfo?(ciprian.georgiu)

(In reply to Brian Grinstead [:bgrins] from comment #4)

About the intermittency:

  1. Is it randomly happening across many profiles or does it consistently reproduce but only in a certain profile?

It happed consistently only on certain profiles. It seems that now, I can reproduce the issue on all the profiles created using mac 10.15. I've made 10 clean profiles, and on each of them the issue reproduced.

  1. The JS error helps - are you only seeing that when it doesn't work or are you seeing that even on profiles / STR where it doesn't reproduce?

Only on the profiles where the issue can be reproduced.

I will try to re-do the regression range next week, maybe I'll get a different result with some bugs that are actually related.

Brian, I can post a gdrive linked to one of my profiles on which I can reproduce the issue, if that helps somehow. Just let me know.

Flags: needinfo?(ciprian.georgiu)

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #5)

I will try to re-do the regression range next week, maybe I'll get a different result with some bugs that are actually related.

Unfortunately, I'm not having any luck with the regression range, I cannot see any related bugs with form autofill in the pushlog output. I'll remove the regressionwindow-wanted. Please let me know if there's anything I can help with here!

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #5)

(In reply to Brian Grinstead [:bgrins] from comment #4)
Brian, I can post a gdrive linked to one of my profiles on which I can reproduce the issue, if that helps somehow. Just let me know.

Sure, we can try that - can you share a link?

Flags: needinfo?(ciprian.georgiu)

(In reply to Brian Grinstead [:bgrins] from comment #7)

Sure, we can try that - can you share a link?

Sorry for taking so long to share this with you. I've uploaded the profile here.

Flags: needinfo?(ciprian.georgiu)

Brian, do you have an update on this bug? Thanks

Flags: needinfo?(bgrinstead)

Hey Dimi, can you see if this is still reproducing? I believe we fixed the credit card autofill issue on MacOS and this might be that same bug.

Flags: needinfo?(dlee)

From Comment 3
TypeError: item._adjustAcItem is not a function autocomplete-popup.js:496:16 Invalid type for value parameter.
I think this is the same issue as Bug 1717603.

Hi Ciprian, Could you help verify whether this issue is fixed in 92? thanks!

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(dlee) → needinfo?(ciprian.georgiu)
Resolution: --- → DUPLICATE

(In reply to Dimi Lee [:dimi] from comment #11)

Hi Ciprian, Could you help verify whether this issue is fixed in 92? thanks!

No, I cannot reproduce the issue anymore with 92.0 RC, under macOS 10.15 or macOS 11.

Flags: needinfo?(ciprian.georgiu)
You need to log in before you can comment on or make changes to this bug.