Closed Bug 1697470 Opened 9 months ago Closed 9 months ago

Update video element context menu

Categories

(Firefox :: Menus, enhancement, P2)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: Gijs, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-context-menus])

Attachments

(1 file)

Spec: https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6011b061#slide=id.gbcc1627a53_1_1

(slide 101)

If it hasn't already made it to m-c, you probably want to apply the patch from bug 1690030 locally first.

Then:

  • the Play Speed item should get re-labeled to "Speed" (remember to rev. localization identifiers when updating strings)
  • its submenu items get relabeled to just 0.5x / 1.0x etc. (drop the English bits of the label)
  • hide/show controls should be underneath the "full screen" item
  • update the label for PiP to "Watch in Picture-in-Picture"
  • open video in new tab (see bug 1690030) and the PiP item should be in their own group (separator above and below)
  • relabel "Save snapshot as..." to "Take Snapshot..." and move it above "save video as..."
  • move "copy video link" below "save video as"

(some of these steps may have been completed already - please check carefully)

As a test page, you can use https://www.w3.org/2010/05/video/mediaevents.html .

The markup lives in https://searchfox.org/mozilla-central/source/browser/base/content/browser-context.inc , the strings in https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/browserContext.ftl and the logic for showing/hiding (which shouldn't need any updates, but just in case...) is in https://searchfox.org/mozilla-central/source/browser/base/content/nsContextMenu.js .

Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P2
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/002cb7a830ed
Update video element context menu. r=Gijs,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Verified that the changes from comment 0 are now visible in Latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04) and are per Spec. Also their functionality is not affected by the changes.

Status: RESOLVED → VERIFIED
See Also: → 1706444
See Also: 1706444

... and here I was just getting used to the keyboard shortcuts as well...

You need to log in before you can comment on or make changes to this bug.