Update video element context menu
Categories
(Firefox :: Menus, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | verified |
People
(Reporter: Gijs, Assigned: mtigley)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-context-menus])
Attachments
(1 file)
(slide 101)
If it hasn't already made it to m-c, you probably want to apply the patch from bug 1690030 locally first.
Then:
- the Play Speed item should get re-labeled to "Speed" (remember to rev. localization identifiers when updating strings)
- its submenu items get relabeled to just 0.5x / 1.0x etc. (drop the English bits of the label)
- hide/show controls should be underneath the "full screen" item
- update the label for PiP to "Watch in Picture-in-Picture"
- open video in new tab (see bug 1690030) and the PiP item should be in their own group (separator above and below)
- relabel "Save snapshot as..." to "Take Snapshot..." and move it above "save video as..."
- move "copy video link" below "save video as"
(some of these steps may have been completed already - please check carefully)
As a test page, you can use https://www.w3.org/2010/05/video/mediaevents.html .
The markup lives in https://searchfox.org/mozilla-central/source/browser/base/content/browser-context.inc , the strings in https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/browserContext.ftl and the logic for showing/hiding (which shouldn't need any updates, but just in case...) is in https://searchfox.org/mozilla-central/source/browser/base/content/nsContextMenu.js .
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/002cb7a830ed Update video element context menu. r=Gijs,fluent-reviewers
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
||
Comment 4•3 years ago
|
||
Verified that the changes from comment 0 are now visible in Latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04) and are per Spec. Also their functionality is not affected by the changes.
|
||
Comment 5•3 years ago
|
||
... and here I was just getting used to the keyboard shortcuts as well...
Description
•