Open Bug 1697506 Opened 3 years ago Updated 2 years ago

[Proton] Update dialog styling for content handling application chooser per new spec

Categories

(Firefox :: File Handling, enhancement, P3)

Desktop
All
enhancement
Points:
3

Tracking

()

Tracking Status
firefox88 --- affected

People

(Reporter: Gijs, Unassigned, NeedInfo)

References

(Blocks 2 open bugs)

Details

(Keywords: helpwanted, Whiteboard: [proton-modals])

See https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=5%3A2 ("Firefox Modals" section in the figma spec, column "spec 2 / "External protocol handler")

Code is in https://searchfox.org/mozilla-central/source/toolkit/mozapps/handling/content/appChooser.xhtml .

  • selected item in the richlistbox should not have a different background, but get a checkmark instead
  • up to 3 items should be reliably visible in the richlistbox without a scrollbar (keep in mind that we can't make assumptions about font size and thus individual item height; we'll need to use em or similar to size the box). If there are fewer items, the box should be less tall.
  • stop showing "choose application" as a row in the list, but show as a separate button instead ("Choose other application...", use the .small button class)
  • show only the domain/hostname for the handler, and show it on the same line as the name (but with a smaller font size / different foreground colour)
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
See Also: → 1701952
Whiteboard: [proton-modals] → [proton-modals][priority:2a]
Priority: P2 → P1
Priority: P1 → P2
Whiteboard: [proton-modals][priority:2a] → [proton-modals] [priority:2a]
Priority: P2 → P3

Clearing p2a whiteboard given this got marked P3.

Doug, are you actively working on this?

Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [proton-modals] [priority:2a] → [proton-modals]

Ack, sorry, no. I can still take this if extra hands are needed and it's any priority, though.

Assignee: dothayer → nobody
Status: ASSIGNED → NEW
Blocks: 1730929
Points: --- → 3
Blocks: 1701253
You need to log in before you can comment on or make changes to this bug.