1697533 - Update the Bookmarks toolbar button menu organization and style

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

The menu item organization and string changes can happen immediately without being behind a Proton pref.

* Remove the "Show All Bookmarks" item at the top of the list (it's redundant, given the "Show All Bookmarks" item at the bottom of the list)
* Change the "Show All Bookmarks" string for the footer to be Manage Bookmarks (title case for now, but the idea is to put it in sentence case later)

• Remove the "Show All Bookmarks" item at the bottom of the list
• Change the "Show All Bookmarks" string for the top item to be Manage Bookmarks (title case for now, but the idea is to put it in sentence case later)

Comment 1

[Tim Nguyen :ntim]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #0)

The menu item organization and string changes can happen immediately without being behind a Proton pref.

• Remove the "Show All Bookmarks" item at the top of the list (it's redundant, given the "Show All Bookmarks" item at the bottom of the list)
• Change the "Show All Bookmarks" string for the footer to be Manage Bookmarks (title case for now, but the idea is to put it in sentence case later)

Just wondering, can't the top item be kept instead of the bottom one? The reason both exist is that some users have lots of bookmarks, and the bottom one is very hard to reach in that case.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm inclined to agree with ntim in comment 1. Tyler, would this be acceptable?

Comment 3

[Romain Testard [:RT]]

This was proposed for consistency with the bookmarks sub-section of the app menu but agreed that there can be a usability issue here.
I see 2 options:
1 Persist the bottom part of the menu when scroll is enabled (same as bookmark app menu section) - my preferred if similar engineering cost
2 Do as ntim suggests

NI_ing Betsy and Meridel for visibility in case they disagree

Comment 4

[Meridel [:meridel]]

I agree with Romain's proposal to "Persist the bottom part of the menu when scroll is enabled (same as bookmark app menu section)" if this does not cost ENG too much.

We would like to have consistency across menus, and this would provide consistency in both information architecture and behavior.

Mike, is this approach feasible?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Meridel [:meridel] from comment #4)

Mike, is this approach feasible?

Given our remaining time, I don't think it is, no.

Comment 6

[Tyler Duzan]

Given that we recognize the usability concern and the timeline/scope limits for engineering, it seems like doing as ntim suggested is the most useful path forward. What are the impacts to UX for this, and can this be made to work in the current design? Adding Meridal and Betsy back for agreement/alternatives.

Comment 7

[Meridel [:meridel]]

Attachment: Bookmark Tray-2.png.pdf

Since we are using different language to describe this menu, I want to clarify that we are indeed talking about the Bookmarks tray menu, yes? That menu will only appear if someone added it via Customize. Toolbar items added via Customize are not a high priority for Proton so I am fine to move ahead with ntim's suggestion. Here is the mock to make sure we are all on the same page.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Yes, this is the bookmarks tray menu. Okay, I have the necessary information to proceed - we'll remove the footer and instead have a "Manage Bookmarks" item as the second item from the top. I'll update comment 0.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1697533 - Update the organization of the Bookmarks toolbar menu popup, and change style for Proton. r?mak!,harry!

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Hey rtestard, some concerns have been raised regarding removing the footer item in the bookmarks tray panel. See https://phabricator.services.mozilla.com/D109151#3550926 and above.

Would you accept if we just restyled the footer to match the Proton menu item spec, and defer any kind of removal here? We'd keep both "Manage Bookmarks" menu items in that case.

Comment 12

[Romain Testard [:RT]]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #11)

Hey rtestard, some concerns have been raised regarding removing the footer item in the bookmarks tray panel. See https://phabricator.services.mozilla.com/D109151#3550926 and above.

Would you accept if we just restyled the footer to match the Proton menu item spec, and defer any kind of removal here? We'd keep both "Manage Bookmarks" menu items in that case.

OK let's do as you suggest given it seems to be more complex than anticipated. Not great to have duplicate items here but it's not a regression and this UI only appears when users enable it through the customization pane so visibility is low. We should not risk shipping MR1 for this.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbc577904b3f
Update the organization of the Bookmarks toolbar menu popup, and change style for Proton. r=mak,harry,desktop-theme-reviewers

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fbc577904b3f