1697555 - Remove Accounts Ecosystem Telemetry supporting code from tree

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

With AET being removed to make room for other ways to solve some problems, we can and should remove the Telemetry-side supports.

This includes:

• t/c/t/pings/EcosystemTelemetry.jsm
• Its tests
• And the docs
  • (For the docs we typically move them to the Obsolete Documentation section. Author's choice for moving or removing)

Comment 1

[Chris H-C :chutten]

Oh right, the ID as well. We should stop generating the ecosystem client id in ClientID.jsm, and consider including some code to clear the value on disk and in prefs. Might be fun coordinating this part of the work with bug 1697596, so it might need to come as a follow-up.

Comment 2

[Ryan Kelly [:rfkelly]]

Might be fun coordinating this part of the work with bug 1697596, so it might need to come as a follow-up.

In Bug 1697596, I'm planning to stub out the FxA functions for getting ecosystemAnonId so that they always throw an error. The telemetry code that calls them already wraps them in a try-catch in case of server error, so I expect this will decouple the two halves well enough for our purposes here.

Comment 3

[Ryan Kelly [:rfkelly]]

I'm planning to stub out the FxA functions for getting ecosystemAnonId so that they always throw an error.

Actually I'm just going to remove the functions, which will cause attempts to call them to throw a (slightly less helpful) error, but still an error that will be caught, logged and ignored by the telemetry code.

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1697555 - Remove Telemetry portions of Accounts Ecosystem Telemetry r?dexter!

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1697555 - Remove old Fennec canary client_id detection code. r?dexter!

Depends on D110091

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78264ba0fd85
Remove Telemetry portions of Accounts Ecosystem Telemetry r=Dexter
https://hg.mozilla.org/integration/autoland/rev/2902a9280e76
Remove old Fennec canary client_id detection code. r=Dexter

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/78264ba0fd85
https://hg.mozilla.org/mozilla-central/rev/2902a9280e76