1697596 - Remove ecosystem_anon_id and other AET infra from FxA client code

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task)

Description

[Ryan Kelly [:rfkelly]]

We are no longer pursuing the technical approach for Account Ecosystem Telemetry from Bug 1635652. Let's remove the corresponding code from the tree.

This bug covers removal of:

• AET helper functions in FxAccountsTelemetry.jsm
• Functions for getting/setting ecosystemUserId/ecosystemAnonId in FxAccountsProfileClient.jsm
• Storage of the ecosystem-telemetry scoped key in FxAccountsKeys.jsm
• All of the corresponding tests.

Bug 1697555 will cover the removal of code related to the telemetry ping itself. Since that code calls into the FxA code covered here in this bug, I've added it as a dependency.

Comment 1

[Ryan Kelly [:rfkelly]]

I believe there are also some comments somewhere in our telemetry code saying that the sync ping is old and busted and AET is the new hotness, we should revise those as well.

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: Bug 1697596 - Remove ecosystem_anon_id from FxA client code. r?markh

Comment 3

[Ryan Kelly [:rfkelly]]

Cross-referencing 1697555 Comment 2 for context - that patch in this bug removes the ensureEcosystemAnonId method that is currently called by the ecosystem telemetry code. That code itself is behind a default-off pref, and the method call is wrapped in a try-catch, but for completeness I tested the patch in a build with ecosystem telemetry preffed on. The result was a browser console log line:

ERROR EcosystemTelemetry::Failed to fetch the ecosystem anonymized ID: TypeError: fxAccounts.telemetry.ensureEcosystemAnonId is not a function

And otherwise no observable effects. So I think that's proper and expected and quite suitable for code that is in the process of being deleted. Thanks :markh for lightly pushing back on the need to keep stub methods around.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/719843f5a247
Remove ecosystem_anon_id from FxA client code. r=markh

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/719843f5a247