1697565 - Default buttons don't respect the system accent color

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

In native-themed dialogs, we draw regular buttons with NSButtonCell and default buttons with HITheme. If the system accent color is not blue, this gives a strange frankenstein look.

With "force aqua" off, HITheme buttons also don't adopt the dark appearance properly, IIRC. So switching to NSButtonCell is needed for proper dark mode support.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - WIP: Render default buttons with NSButtonCell.

TODO: Break out the mock active window part, with the following comment:

This causes CellDrawView to follow the system appearance, if widget.macos.respect-system-appearance is set to true:
It will inherit the effective appearance from the NSWindow, which inherits it from the NSApplication.
This makes search fields and checkboxes and so on react to appearance changes
properly. To test checkboxes, you can go to History -> Clear Recent History...

Depends on D107908

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Remove unused bevel button enum values. r=#mac-reviewers

Depends on D108156

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Put the CellDrawView into a (never-shown) NSWindow, to allow drawing active default buttons. r=#mac-reviewers

Depends on D108157

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Draw default buttons with NSButtonCell, so that they adopt the system accent color. r=#mac-reviewers

Depends on D108158

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Use eRegularPushButton for rounded bezel push buttons, because they now draw the same. r=#mac-reviewers

Depends on D108159

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Remove unused bevel button enum values. r=#mac-reviewers

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Put the CellDrawView into a (never-shown) NSWindow, to allow drawing active default buttons. r=#mac-reviewers

Depends on D108161

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1697565 - Draw default buttons with NSButtonCell, so that they adopt the system accent color. r=#mac-reviewers

Depends on D108162

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e7aeaf9b19
Remove unused bevel button enum values. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/4e0b839a26b5
Put the CellDrawView into a (never-shown) NSWindow, to allow drawing active default buttons. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/236dc5dd16e0
Draw default buttons with NSButtonCell, so that they adopt the system accent color. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/df4b939f11b7
Use eRegularPushButton for rounded bezel push buttons, because they now draw the same. r=mac-reviewers,bradwerth

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c2e7aeaf9b19
https://hg.mozilla.org/mozilla-central/rev/4e0b839a26b5
https://hg.mozilla.org/mozilla-central/rev/236dc5dd16e0
https://hg.mozilla.org/mozilla-central/rev/df4b939f11b7