1697350 - Simplify NSCell focus ring drawing situation

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

We have some old code in nsNativeThemeCocoa.mm which has a bunch of different paths for making sure we draw the right focus rings in the right cases. We can simplify this code considerably.

This blocks bug 1077365 because it's necessary for proper NSTextFieldCell focus rings, and it blocks bug 1697336 because that bug switches the style of the search field cell in the library toolbar, and its focus ring will look wonky without this fix.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1697350 - Simplify focus ring drawing code for search fields.

We use these searchfields in the bookmarks sidebar, and in the toolbar in the
bookmarks library window.

The old code was a workaround for missing focus rings.
It turns out that NSTextFieldCell only draws focus rings if the object passed
to inView: is an NSControl. So if we make CellDrawView inherit from NSControl,
we get the focus ring.

Depends on D107751

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1697350 - Simplify focus ring drawing code for search fields. r=#mac-reviewers

We use these searchfields in the bookmarks sidebar, and in the toolbar in the
bookmarks library window.

The old code was a workaround for missing focus rings.
It turns out that NSTextFieldCell only draws focus rings if the object passed
to inView: is an NSControl. So if we make CellDrawView inherit from NSControl,
we get the focus ring.

Depends on D107907

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/808f023d33cc
Simplify focus ring drawing code for search fields. r=mac-reviewers,haik

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/808f023d33cc