1697585 - Making input tasks more strictly aligned with vsync

Status: RESOLVED FIXED

(Core :: Performance: General, task)

Description

[Sean Feng [:sefeng211]]

The idea is to be able to handle more input tasks before vsync, and doing fewer input tasks while vsync.

Comment 1

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Add VsyncTaskManager r=bas,smaug

Introduce a new TaskManager called HighPriorityTaskManager for
EventQueuePriority::High tasks.

Comment 2

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Make input tasks can be more strictly aligned with Vsync r=smaug

This patch introduces a new way to way to schedule input tasks, such
that input tasks remain at InputHigh priority normally, however, when
there's a pending High priority task (Vsync tasks) in the task queue, we
increase the priority of input tasks from InputHigh to Vsync to
process the pending input tasks.

There are two restrictions to ensure we don't delay vsync too much:

• There's a hard limit duration
• We won't process the input tasks that are newly added after we've
  started to process the current number of input tasks

Depends on D109498

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Rename high priority to vsync priority r=smaug

High priority is being used for vsync tasks, so we should rename it to
make it clear, and renaming it also makes our priority naming less
confusing.

Comment 4

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug

Depends on D109499

Comment 5

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug

Some tests need to wait for a full tick cycle to ensure the expected
input tasks are run.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074ebebaee27
Rename high priority to vsync priority r=smaug
https://hg.mozilla.org/integration/autoland/rev/0b1bc6cb84af
Add VsyncTaskManager r=bas,smaug
https://hg.mozilla.org/integration/autoland/rev/d8516aec6a5e
Make input tasks can be more strictly aligned with Vsync r=smaug
https://hg.mozilla.org/integration/autoland/rev/bc271f42bcb7
Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug
https://hg.mozilla.org/integration/autoland/rev/e9e4a710e7d1
Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1697585) for causing build bustages on nsTimerImpl.h
https://hg.mozilla.org/integration/autoland/rev/dc555adb9f36ecb4caeba9d1b56f4d3fd1f9f1ba

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=e9e4a710e7d15a3ace7764483a5cfceb6e2713c9&selectedTaskRun=IrgdUtALQ9m-hNm-gghqiQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=335564750&repo=autoland&lineNumber=49213

Comment 8

[Sean Feng [:sefeng211]]

Attachment: Bug 1697585 - Prevent starting scrolling again in the child process if preventClickEvent has been called r=masayuki,smaug

Currently, for auto scroller, when a mousedown happens, a possible run order is that
mousedown(parent process) -> scroll stopped (parent process) ->
mousedown(child process), so that the last mousedown(child process)
would start the scrolling again.

This patch adds a new check to the last mousedown(child process)
handler, to not starting the scrolling again if preventClickEvent has
been called on this event.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed6175e0c7b
Rename high priority to vsync priority r=smaug
https://hg.mozilla.org/integration/autoland/rev/4031cca20f28
Add VsyncTaskManager r=bas,smaug
https://hg.mozilla.org/integration/autoland/rev/c206669072a4
Make input tasks can be more strictly aligned with Vsync r=smaug
https://hg.mozilla.org/integration/autoland/rev/ca2243d8f565
Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug
https://hg.mozilla.org/integration/autoland/rev/eebe83ba4c97
Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/0ce8cafaccaf
Prevent starting scrolling again in the child process if preventClickEvent has been called r=masayuki,smaug

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8ed6175e0c7b
https://hg.mozilla.org/mozilla-central/rev/4031cca20f28
https://hg.mozilla.org/mozilla-central/rev/c206669072a4
https://hg.mozilla.org/mozilla-central/rev/ca2243d8f565
https://hg.mozilla.org/mozilla-central/rev/eebe83ba4c97
https://hg.mozilla.org/mozilla-central/rev/0ce8cafaccaf