1697633 - GV Content Permissions overhaul part 1: add getPermission and permission reporting

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Dylan Roeh (:droeh) (he/him)]

This is the first chunk of bug 1654832, representing stuff we can do without flipping the switch and moving permission storage to Gecko properly. We add some getPermissions functionality to StorageController and report current permissions in the NavigationDelegate.onLocationChange callback. It's breaking in that it changes the signature of onLocationChange, but behavior is otherwise identical.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1697633 - Update onLocationChange to include permission reporting; add getAllPermissions and getPermissions to StorageController. r=#geckoview-reviewers!,agi!

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1697633 - Add tests for getPermissions and onLocationChange permission reporting. r=#geckoview-reviewers!

Depends on D107927

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7bbf31acfbc
Update onLocationChange to include permission reporting; add getAllPermissions and getPermissions to StorageController. r=agi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/789b7a6daf18
Add tests for getPermissions and onLocationChange permission reporting. r=geckoview-reviewers,agi

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d7bbf31acfbc
https://hg.mozilla.org/mozilla-central/rev/789b7a6daf18