1697722 - Implement unit converter as UrlbarProvider

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Daisuke Akatsuka (:daisuke)]

Implement the unit converter as UrlbarProvider we made as a prototype.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1697722: Implement unit converter as UrlbarProvider.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1697722: Add tests for unit conversion.

Depends on D107968

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e1236cb9f03
Implement unit converter as UrlbarProvider. r=adw,dminor
https://hg.mozilla.org/integration/autoland/rev/bacefd6c7f00
Add tests for unit conversion. r=adw

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2e1236cb9f03
https://hg.mozilla.org/mozilla-central/rev/bacefd6c7f00

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for time dependent permanent failure in test_unitConversion.js:

https://hg.mozilla.org/mozilla-central/rev/16fa53e061a7415ba8eca0c509d4526ea5a3d25a

Failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=VQoxbVP9S5OIDnXLiUbpYg.1&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a298c011de58aeba36832f08f44b3e0231ef1411&searchStr=xpcshell
Failure log: https://treeherder.mozilla.org/logviewer?job_id=337905631&repo=autoland

Comment 6

[Daisuke Akatsuka (:daisuke)]

I updated the test and wait for review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/065e0e7d5d39
Implement unit converter as UrlbarProvider. r=adw,dminor
https://hg.mozilla.org/integration/autoland/rev/acd8f166926a
Add tests for unit conversion. r=adw

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/065e0e7d5d39
https://hg.mozilla.org/mozilla-central/rev/acd8f166926a