Closed Bug 1697947 Opened 7 months ago Closed 6 months ago

Extend Proton button styles to more panels

Categories

(Firefox :: Theme, task)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers])

Attachments

(1 file)

This is a big one. We've been doing kind of piece-meal spot application of the Proton button spec, and I don't think that's sustainable. I'm going to try the same technique from bug 1697315 and bug 1697863, and have the Proton pref switch us to a non-native button by default. This will also include the option for a native attribute that can be applied to the button to fallback to the old native style.

I tried this, and broke sufficient numbers of things layout-wise to scare me off, at least for now. Maybe worth doing in the future to avoid repeating Proton button style rules all over the place, but I don't think we have time to do this. I'm going to transmute this bug into applying Proton styles to more buttons (like the Bookmarks Panel), and to special-case a few buttons that actually need to look like menu items with Proton enabled (most footer buttons, for example).

Summary: Add preliminary Proton styles for browser UI buttons → Extend Proton button styles to more panels
Assignee: nobody → mconley
Attachment #9208792 - Attachment description: Bug 1697947 - Apply Proton button stylings to more panels. r?harry! → Bug 1697947 - Apply Proton button stylings to the footers of more panels. r?harry!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c35c310c49d3
Apply Proton button stylings to the footers of more panels. r=harry
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4f65bafec7d
Apply Proton button stylings to the footers of more panels. r=harry
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.