1697947 - Extend Proton button styles to more panels

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Mike Conley (:mconley) (:⚙️)]

This is a big one. We've been doing kind of piece-meal spot application of the Proton button spec, and I don't think that's sustainable. I'm going to try the same technique from bug 1697315 and bug 1697863, and have the Proton pref switch us to a non-native button by default. This will also include the option for a native attribute that can be applied to the button to fallback to the old native style.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I tried this, and broke sufficient numbers of things layout-wise to scare me off, at least for now. Maybe worth doing in the future to avoid repeating Proton button style rules all over the place, but I don't think we have time to do this. I'm going to transmute this bug into applying Proton styles to more buttons (like the Bookmarks Panel), and to special-case a few buttons that actually need to look like menu items with Proton enabled (most footer buttons, for example).

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1697947 - Apply Proton button stylings to the footers of more panels. r?harry!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c35c310c49d3
Apply Proton button stylings to the footers of more panels. r=harry

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset c35c310c49d3 (Bug 1697947) for causing failures in browser_parsable_css.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=B1bFmHUOQmiajsddZ47G_w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c35c310c49d393173159f199174d6c0d6ba455dc

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333443891&repo=autoland&lineNumber=1634

Backout: https://hg.mozilla.org/integration/autoland/rev/618e8ec8dd2e1dde6ca828fcf104f5be8a601ac9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4f65bafec7d
Apply Proton button stylings to the footers of more panels. r=harry

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b4f65bafec7d