1697964 - More macOS code cleanup after dropping compatibility for old versions of macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P1)

Description

[Markus Stange [:mstange]]

We have some code around which was only needed to support versions of macOS which we've already dropped. Things like respondsToSelector checks that always return true, some missed code simplifications, etc.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1697964 - Remove unnecessary cast. r=#mac-reviewers

Before we required the 10.12 SDK for compilation, this cast was needed because
we were declaring the enum value outside of the enum type:
https://searchfox.org/mozilla-central/rev/ca910762568921c0faa34838d6a4efac2471dff1/widget/cocoa/VibrancyManager.mm#15-16

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1697964 - Remove respondsToSelector checks that always return true on 10.12+. r=#mac-reviewers

Depends on D108133

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1697964 - Remove GetQuarantinePropKey(). r=#mac-reviewers

GetQuarantinePropKey() used to contain a version check for pre-10.10, which
was removed in bug 1673051.

Depends on D108134

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1697964 - Remove nsCocoaUtils::EventPhase and EventMomentumPhase. r=#mac-reviewers

This has been unnecessary ever since we dropped support for 10.6 in Firefox 49.

Depends on D108135

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1697964 - Remove nsCocoaUtils::GetScrollingDeltas and HasPreciseScrollingDeltas. r=#mac-reviewers

This code has been unnecessary since we dropped suppor tfor 10.6 in Firefox 49.

Depends on D108136

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e65b634cf4e4
Remove unnecessary cast. r=mac-reviewers,tnikkel
https://hg.mozilla.org/integration/autoland/rev/c34f487bd399
Remove respondsToSelector checks that always return true on 10.12+. r=mac-reviewers,tnikkel
https://hg.mozilla.org/integration/autoland/rev/9119b506a47f
Remove GetQuarantinePropKey(). r=mac-reviewers,tnikkel
https://hg.mozilla.org/integration/autoland/rev/0a824f732082
Remove nsCocoaUtils::EventPhase and EventMomentumPhase. r=mac-reviewers,tnikkel
https://hg.mozilla.org/integration/autoland/rev/26cb0a7bac9b
Remove nsCocoaUtils::GetScrollingDeltas and HasPreciseScrollingDeltas. r=mac-reviewers,tnikkel

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e65b634cf4e4
https://hg.mozilla.org/mozilla-central/rev/c34f487bd399
https://hg.mozilla.org/mozilla-central/rev/9119b506a47f
https://hg.mozilla.org/mozilla-central/rev/0a824f732082
https://hg.mozilla.org/mozilla-central/rev/26cb0a7bac9b