1698032 - New Proton Tabs Bar design does not blend well with the Windows 7 specific glassy window

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Affected Version:
Firefox Nightly 88.0a1
In about:config set
browser.proton.enabled = true
browser.proton.tabs.enabled = true

Affected Platform:
Windows 7

Steps to reproduce:

1. Launch Firefox Nightly with proton prefs enabled on Windows 7
2. Open multiple tabs and don't maximize the browser

Expected Result:
The new proton tabs design should blend better or match with the default Windows 7 glassy window. Increasing/Decreasing the transparency in windows7 window settings outlines this issue even more.

Actual Result:
Proton Tabs does not blend well with the Windows 7 specific glassy window when the window is not maximized

Screenshot 1: https://drive.google.com/file/d/1wFYOHN9KCPPFVijEs_j42KdsGuC3hxFT/view?usp=sharing
Screenshot 2: https://drive.google.com/file/d/1etrKBNhTg9tkG8Mnnyq9LXwJtnnui0-s/view?usp=sharing

Comment 1

[Dão Gottwald [:dao]]

At the very least we can add padding to the start of the tab strip so that the first tab isn't glued directly to the border.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1698032 - Improve proton tab bar design for Windows 7.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d92e2c156f8
Improve proton tab bar design for Windows 7. r=mconley

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3d92e2c156f8

Comment 5

[Tim Nguyen :ntim]

Hi Timea, could you check if this works nicely on Windows 7 in various situations? I'd be interested to know about various situations like with menubar/titlebar on, wide monitors, various system themes, etc. or whatever makes sense for you to test :)

While you're there, could you check whether some Windows 7 tab-related bugs filed for proton (the ones by QA at least) can now be closed?

Thanks!

Comment 6

[Timea Cernea [:tbabos][inactive]]

Hi Tim, this is the kind of issue that one might say you need to check it out with your own eyes to get the whole picture but summing it up:

Good Points:

• it looks way better now for Light Theme

Issues:

• something goes really wrong when Proton Dark (or Dark) is enabled, see recording: https://streamable.com/wsw0rp
• default theme now looks exactly like Light Theme, here is a comparison before the fix and after: https://streamable.com/xosojz
• unfocusing the browser window will have the close/minimize/maximize button overlapped (all themes)

So this indeed provided improvements for the design but only with the Light theme, the default one (which for some reason I recall Romain saying that Proton Light will be the new default theme, not sure if anything has to do with it) does not offer any changes and Proton Dark needs to be addressed and fixed. I check it out with menubars, 0 and 100% window transparency setting, low resolution. FYI, I don't have a widescreen monitor to also cover that point.
So I can't call this fixed unless you will scope down the fix for this to be only for the Light theme and the bugs mentioned to be worked on separately. Let me know how it should go.

For the rest of the tabs bar issues on Windows 7, Hani Yacoub (QA owner - Proton: Tabs bar) will look over them.

Comment 7

[Timea Cernea [:tbabos][inactive]]

Attachment: Light theme after fix