Closed Bug 1698062 Opened 3 years ago Closed 3 years ago

[Proton] Hamburger Menu is too wide using DE builds

Categories

(Firefox :: Menus, defect, P2)

Firefox 88
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: ailea, Assigned: emmamalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu][priority:2a])

Attachments

(2 files, 1 obsolete file)

Attached image 2021-03-12_14h17_11.png

Tested with:

Nightly 88.0a1 (2021-03-12)

Tested on:

Windows 10
Windows 7
MacOS 11
Ubuntu 20.04

Preconditions:

In about:config, set browser.proton.enabled = true
Have a DE build installed.

Steps:

  1. Launch a DE firefox Nightly build and open the Hamburger menu.

Actual result:

The Hamburger menu is too wide.

Expected result:

The long strings should be displayed in two rows (according to Figma) and the Hamburger Menu should have the same size like in other builds.

Notes:

In Figma, the Hamburger menu from DE builds has the normal size and the long strings are displayed in two rows.

What happens for the row "Erweiterungen und Themes [space] Strg+Umschalt+A" - which I assume is in Windows while the Figam layouts all show the shorter macOS options?

Mike, can you set a priority here based on where this falls on the MR1 list? Thanks.

Severity: -- → S3
Flags: needinfo?(mconley)
Flags: needinfo?(mconley)
Priority: -- → P2

Hi, Please note that this issue also occurs on the FxA menu after the user syncs the tabs, with CN as well as AR builds.

Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu][priority:2a]
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfff0c88a1bd
set app menu width and ensure text can wrap r=fluent-reviewers,mconley,flod
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1702849

Comment on attachment 9213577 [details]
Bug 1698062, adjust menu panel widths when proton is enabled

Revision D110814 was moved to bug 1702849. Setting attachment 9213577 [details] to obsolete.

Attachment #9213577 - Attachment is obsolete: true
Regressions: 1703405
See Also: → 1704045

Verified - Fixed in latest Nightly 89.0a1 (2021-04-08). The hamburger menu size is normal now, but there is a similar issue with the FxA toolbar panel when the user is using a long email address for fx account. See bug 1704045 (it is not a regression caused by this fix).

Status: RESOLVED → VERIFIED
See Also: → 1712518
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: