Closed Bug 1702849 Opened 3 years ago Closed 3 years ago

Gecko Profiler pop-up is cut

Categories

(Firefox :: Menus, defect, P3)

Product:
Firefox
Component:
Menus
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed

People

(Reporter: mayankleoboy1, Assigned: emmamalysz)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-hamburger-menu])

Attachments

(2 files)

bug.png
8.89 KB, image/png
Details
Bug 1702849, adjust menu panel widths when proton is enabled
48 bytes, text/x-phabricator-request
Details | Review
Attached image bug.png —
  1. Use new profile
  2. Enable gecko profiler
  3. Click on icon

AR: popup is cut off from right

Keywords: regression

2021-04-03T07:58:15.226000: INFO : Narrowed integration regression window from [4e78866f, dfa41bd4] (3 builds) to [4e78866f, cfff0c88] (2 builds) (~1 steps left)
2021-04-03T07:58:15.247000: DEBUG : Starting merge handling...
2021-04-03T07:58:15.247000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=cfff0c88a1bd67d89101b147f6173d735afe56cf&full=1
2021-04-03T07:58:15.247000: DEBUG : redo: attempt 1/3
2021-04-03T07:58:15.247000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=cfff0c88a1bd67d89101b147f6173d735afe56cf&full=1',), kwargs: {}, attempt #1
2021-04-03T07:58:15.254000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2021-04-03T07:58:17.381000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=cfff0c88a1bd67d89101b147f6173d735afe56cf&full=1 HTTP/1.1" 200 None
2021-04-03T07:58:17.459000: DEBUG : Found commit message:
Bug 1698062: set app menu width and ensure text can wrap r=fluent-reviewers,mconley,flod

Differential Revision: https://phabricator.services.mozilla.com/D110461

2021-04-03T07:58:17.459000: DEBUG : Did not find a branch, checking all integration branches
2021-04-03T07:58:17.459000: INFO : The bisection is done.
2021-04-03T07:58:17.459000: INFO : Stopped

Regressed by: 1698062
Has Regression Range: --- → yes
Component: Widget: Win32 → Menus
Product: Core → Firefox

Gah, I think I missed that the rule in bug 1698062 should probably be restricted to just the AppMenu panel. The one that got added applies to #customizationui-widget-multiview panelview:not([extension]) as well, and it probably shouldn't.

emalysz, do you have time to look at this?

Flags: needinfo?(emalysz)
Severity: -- → S2
status-firefox88: --- → unaffected
status-firefox89: --- → affected
OS: Unspecified → All
Hardware: Unspecified → Desktop
Blocks: proton-hamburger-menu
Whiteboard: [proton-hamburger-menu]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Flags: needinfo?(emalysz)
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9e9dcbb9d48
adjust menu panel widths when proton is enabled r=mconley
Priority: -- → P3

https://hg.mozilla.org/mozilla-central/rev/f9e9dcbb9d48

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: