1698143 - Calendar: Dialog persistence stopped working

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[[e-mail]]

Bug 1598050 converted some Lightning dialogs so that their <dialog> element was no longer the root element. Unfortunately, the id was an important persistence attribute on the root element which should not have been moved to the <dialog> element.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Some places were actually using the id to refer to the <dialog> element. I've changed these to document.querySelector("dialog"), as used e.g. https://searchfox.org/mozilla-central/search?q=document.querySelector%28%22dialog%22%29

Comment 2

[Martin Schröder [:mschroeder]]

Bug 1659117 and Bug 1675981 for two specific dialogs had already been created with the same diagnostics. These should probably be marked as duplicate of this bug then.

Comment 5

[Ben Bucksch (:BenB)]

Comment on attachment 9208734 [details] [diff] [review]
Proposed patch

@neil: Could you please (or confirm that you already did):

• Test each dialog you touch
• Search for each ID that you move, whether you forgot/overlooked a code instance that needs to be adapted?

Comment 6

[[e-mail]]

(In reply to Ben Bucksch from comment #5)

• Test each dialog you touch

I only tested the ones I know how to open.

• Search for each ID that you move, whether you forgot/overlooked a code instance that needs to be adapted?

Every time I moved an ID, I searched for it so that I could fix up any code instances that were using it.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9208734 [details] [diff] [review]
Proposed patch

Thanks. This should've happened at the time, but better late than never I guess.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a114a7fd9c58
Restore id attributes to dialog root elements (to fix persistance). r=darktrojan

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fc1b044f9eb
follow-up - Fix broken test browser_customMinimonthCount.js. rs=bustage-fix

Comment 11

[Thomas D. (:thomas8)]

(In reply to Pulsebot from comment #8)

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a114a7fd9c58
Restore id attributes to dialog root elements (to fix persistance). r=darktrojan

Would have been good to mention in the commit message and bug summary that his has been fixed only for our Calendar component.