Closed Bug 1698237 Opened 4 years ago Closed 4 years ago

Extension icon lost color after bug 1697806

Categories

(Toolkit :: Themes, defect)

Firefox 88
defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: 1justinpeter, Assigned: ntim)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached file Test Extension.zip

I don't know for absolute certain that it was bug 1697806, but the time window matches and that seems the most likely candidate. I can download an old nightly build to verify (and get a picture) if that would be helpful.

Steps to reproduce:

  1. Enable the installation of unsigned extensions by changing xpinstall.signatures.required to false in about:config.
  2. Go to about:addons and click "install addon from file" in the settings dropdown (a minimal extension is attached).
  3. Note that the icon is gray in both the toolbar and about:addons. (It was previously green.)

I'm not sure that the change is necessarily bad, but if it was unintended I thought I should let you know.

Flags: needinfo?(ntim.bugs)
Attached image Current extension icon
Regressed by: 1697806
Has Regression Range: --- → yes

I think I know what's happening, thanks for filing this bug!

Assignee: nobody → ntim.bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(ntim.bugs)

This bug is...annoying. So, while both green images from bug 1697806 are the same, extensionGeneric.svg never actually gets packaged, instead category-extensions.svg (a non-colored icon) gets packaged twice, once as extensionGeneric.svg, once as category-extension.svg... So what I did in bug 1697806 was incorrect. I'm going to back out the original patch from bug 1697806 for now.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

I can confirm that it's fixed (but can't mark the bug as verified, apparently).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: