1698302 - progress and meter display wrong width, don't match html value parameter

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Bill Goldstein [:aja] (UTC-6)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

data:text/html,<progress max=1 value=.5></progress>
data:text/html,<meter high=.66 low=.33 max=1 min=0 optimum=.5 value=.25></meter>
data:text/html,<meter high=.66 low=.33 max=1 min=0 optimum=.5 value=.5></meter>
data:text/html,<meter high=.66 low=.33 max=1 min=0 optimum=.5 value=.75></meter>

Actual results:

Indicators are wrong width...too narrow

Expected results:

Indicators should match up with html value parameter.
Problem not found on beta/dev 87, broken on trunk.

Comment 1

[Bill Goldstein [:aja] (UTC-6)]

This appears to be specific to Non-Native Theme...at least on win.
Sorry, but having issues getting moz-regression to run :(

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698302 - Paint progress/meter chunks along with the track. r=mstange

The progress chunk already has the right size, but it's easier to get
the right clipping if we just paint it as part of the progress bar.

This is much like we paint the range track and thumb. We apply the
native appearance atomically so this should be fine.

Comment 3

[Bill Goldstein [:aja] (UTC-6)]

Finally got mozregression running, pointed to Bug 1689252, as you probably already figured out.

Comment 4

[Bill Goldstein [:aja] (UTC-6)]

Figured it must be something like that, since low/optimum/high colors looked right, which made me assume DOM values must be okay.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698302 - bonus: support indeterminate progress meter. r=mstange

I wonder if we could do something more fancy with the animation than
QueueAnimatedContentForRefresh, which is timer based, like a
transform-like animation that WebRender could run or something, but this
is probably good enough for now.

Depends on D108335

Comment 6

[Bill Goldstein [:aja] (UTC-6)]

Not for this bug but, FWIW, IMHO, don't think you'd hear much screaming about non-animating progress. Nor if meter chunk was flat, rather than linear-gradient.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71549d995fb4
Paint progress/meter chunks along with the track. r=mstange
https://hg.mozilla.org/integration/autoland/rev/0b34c40347da
bonus: support indeterminate progress meter. r=mstange

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/71549d995fb4
https://hg.mozilla.org/mozilla-central/rev/0b34c40347da