Closed Bug 1698349 Opened 1 year ago Closed 10 months ago

Rename small/medium class to {small/medium}-button

Categories

(Toolkit :: Themes, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: ntim, Assigned: pasulaav)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file, 2 obsolete files)

This is mainly to be consistent with ghost-button/danger-button and to prevent any conflicts with potential small/medium classes defined in other files in the future.

It would be also worth using these small/medium classes in about:addons and other places overriding the default padding.

Otherwise, I think those classes should just be deleted if they remain unused.

Whiteboard: [proton-cleanups]
Priority: -- → P3
Points: --- → 1

I don't actually think these classes are being used. I'm tempted to just remove them unless we want to turn this bug into one where we define the MR1-theme'd buttons in a way that's shared across the UI, along with these size modes.

Assignee: nobody → pasulaav
Status: NEW → ASSIGNED
Attachment #9240804 - Attachment description: Bug 1698349 - Changed the .small/.medium selectors to .small-button/.medium-button. r=mhowell,mtigley → Bug 1698349 - Changed the .small selectors to .small-button and since there were no uses of medium found that selector was removed . r=mhowell,mtigley
Attachment #9240812 - Attachment is obsolete: true
Attachment #9242388 - Attachment is obsolete: true
Blocks: 1733442
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/f3cf9c079ebb
Changed the .small selectors to .small-button and since there were no uses of medium found that selector was removed . r=mhowell,mtigley,Itiel
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.