1698349 - Rename small/medium class to {small/medium}-button

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

This is mainly to be consistent with ghost-button/danger-button and to prevent any conflicts with potential small/medium classes defined in other files in the future.

Comment 1

[Tim Nguyen :ntim]

It would be also worth using these small/medium classes in about:addons and other places overriding the default padding.

Otherwise, I think those classes should just be deleted if they remain unused.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I don't actually think these classes are being used. I'm tempted to just remove them unless we want to turn this bug into one where we define the MR1-theme'd buttons in a way that's shared across the UI, along with these size modes.

Comment 3

[Avi]

Attachment: Bug 1698349 - Changed the .small selectors to .small-button and since there were no uses of medium found that selector was removed . r=mhowell,mtigley

Comment 4

[Avi]

Attachment: Bug 1698349 - I changed the small-button in a js file. Also remove medium as it wasn't used in the CSS. r=mhowell,mtigley

Depends on D125341

Comment 5

[Avi]

Attachment: Bug 1698349 - Changed the comment in the CSS file to match the edits made to the file. r=mhowell,mtigley

Depends on D125341

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3cf9c079ebb
Changed the .small selectors to .small-button and since there were no uses of medium found that selector was removed . r=mhowell,mtigley,Itiel

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f3cf9c079ebb