1693276 - Add proton styles for in-content buttons

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[:Gijs (he/him)]

See specs in the "Basic-Components" figma.

Padding should be 6/7/8px vertically for small/medium/large buttons, with horizontal padding double that.

4px border radius everywhere.

Colours are settled for light theme, not for dark theme.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1693276 - update button styles for proton

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I presume making these styles shared with toolbarbutton's in the browser chrome is out of scope for this bug?

Comment 3

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #2)

I presume making these styles shared with toolbarbutton's in the browser chrome is out of scope for this bug?

I wasn't planning on trying to address that in this bug, no - sorry. I'll try to update for ntim's suggestions ASAP and then you could try building off of this patch - does that work for you?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Most definitely.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a95ba3c4f1b
update button styles for proton r=desktop-theme-reviewers,ntim

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1a95ba3c4f1b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regression caused by this fix.

For more information, please visit auto_nag documentation.