Closed Bug 1698397 Opened 3 years ago Closed 3 years ago

Port bug 1698043: Input Field of type Number, placeholder blocked by arrows if text-align:right

Categories

(Thunderbird :: Upstream Synchronization, task)

Product:
Thunderbird
Component:
Upstream Synchronization
Type:
task

Tracking

(thunderbird_esr78 unaffected, thunderbird87 unaffected, thunderbird88 affected)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird87 --- unaffected
thunderbird88 --- affected

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

1698397-input-number.patch
5.36 KB, patch
darktrojan
: review+
Details | Diff | Splinter Review
1698397-follow-up.patch
930 bytes, patch
aleca
: review+
Details | Diff | Splinter Review
No description provided.

This fixes the input[type="number"] boxes with the spinbuttons. You find them in a contacts card for the birthday and in the preferences.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9208995 - Flags: review?(geoff)
Depends on: 1698043

Bug 1698043 landed already.

Comment on attachment 9208995 [details] [diff] [review]
1698397-input-number.patch

The code changes are fine. I assume you're happy with how it looks.

Attachment #9208995 - Flags: review?(geoff) → review+
status-thunderbird87: --- → unaffected
status-thunderbird88: --- → affected
status-thunderbird_esr78: --- → unaffected
Keywords: checkin-needed-tb
Target Milestone: --- → 88 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/128dc4359c7f
Port bug 1698043: Input Field of type Number, placeholder blocked by arrows if text-align:right. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Bah, found a rule that I missed to remove.

Attachment #9209482 - Flags: review?(alessandro)
Attachment #9209482 - Flags: review?(alessandro) → review+
Pushed by richard.marti@gmail.com:
https://hg.mozilla.org/comm-central/rev/1164fcea8a72
follow-up to remove a missed rule on Windows. r=aleca DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: