Closed
Bug 1698436
Opened 3 years ago
Closed 3 years ago
Proton customization - re-center several buttons inside the overflow dropdown menu
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
89 Branch
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | disabled |
firefox89 | --- | verified |
People
(Reporter: cfogel, Assigned: mhowell)
References
(Blocks 2 open bugs)
Details
(Keywords: regression, Whiteboard: [proton-toolbar])
Attachments
(2 files)
Affected versions
- 88.0a1 (2021-03-14)
Affected platforms
- Win10, macOS 10.13;
Steps to reproduce
- pref set to true: browser.proton.enabled
- pref set to true: browser.proton.toolbar.enabled
- Launch Firefox, access the Customize browser page;
- Drag all the available buttons in the Overflow menu;
Expected result
- button icons have the same offset from the left-side of panel;
Actual result
- button icons are no longer centered for:
- Reload;
- Profiler;
- Cut / Copy / Paste;
Regression range
- visible with proton-toolbar changes;
Additional notes
- set as S3 for now, since this might still be worked on;
- attached screenshot to better illustrate the issue.
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-547
Updated•3 years ago
|
Summary: Proton customization - re-center several buttons inside the ovreflow dropdown menu → Proton customization - re-center several buttons inside the overflow dropdown menu
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-560
Updated•3 years ago
|
See Also: https://jira.mozilla.com/browse/FIDEFE-560 →
Updated•3 years ago
|
Priority: -- → P2
Comment 1•3 years ago
|
||
Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.
Priority: P2 → P1
Updated•3 years ago
|
Has STR: --- → yes
Assignee | ||
Comment 3•3 years ago
|
||
Gonna give this one a shot, if nobody else is working on it.
Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•3 years ago
|
||
This also fixes an issue with block margins that I noticed while developing
this patch, namely that the Profiler menu item was a few pixels too short
in addition to being offset to the right.
Updated•3 years ago
|
status-firefox89:
--- → affected
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ba9e2a13535 Keep overflow/customize menu items aligned. r=desktop-theme-reviewers,harry
Comment 7•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Comment 8•3 years ago
|
||
I managed to reproduce the issue on an older version of Nightly using Windows 10 x64.
I retested everything using latest Nightly 89.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.. The issue is not reproducing anymore.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
status-firefox87:
--- → unaffected
status-firefox-esr78:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•