1698436 - Proton customization - re-center several buttons inside the overflow dropdown menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: Untitled-2.png

Affected versions

• 88.0a1 (2021-03-14)

Affected platforms

• Win10, macOS 10.13;

Steps to reproduce

• pref set to true: browser.proton.enabled
• pref set to true: browser.proton.toolbar.enabled

1. Launch Firefox, access the Customize browser page;
2. Drag all the available buttons in the Overflow menu;

Expected result

• button icons have the same offset from the left-side of panel;

Actual result

• button icons are no longer centered for:
  • Reload;
  • Profiler;
  • Cut / Copy / Paste;

Regression range

• visible with proton-toolbar changes;

Additional notes

• set as S3 for now, since this might still be worked on;
• attached screenshot to better illustrate the issue.

Comment 1

[Romain Testard [:RT]]

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Comment 3

[Molly Howell (she/her) [:mhowell]]

Gonna give this one a shot, if nobody else is working on it.

Comment 4

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1698436 - Keep overflow/customize menu items aligned. r=mconley

This also fixes an issue with block margins that I noticed while developing
this patch, namely that the Profiler menu item was a few pixels too short
in addition to being offset to the right.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba9e2a13535
Keep overflow/customize menu items aligned. r=desktop-theme-reviewers,harry

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9ba9e2a13535

Comment 8

[Oana Botisan, Desktop Release QA]

I managed to reproduce the issue on an older version of Nightly using Windows 10 x64.
I retested everything using latest Nightly 89.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.. The issue is not reproducing anymore.