Closed Bug 1698577 Opened 6 months ago Closed 6 months ago

Revert naming change of preferences/settings for 88 release

Categories

(Firefox :: Menus, defect, P1)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

I should have caught this in bug 1695671, but we don't intend for the preferences/options vs. settings change to go out in 88, so we shouldn't update the menu items there.

We can either back it out now and then revert the backout in the 89 cycle, or we can write a backout patch and make sure we land it on beta before b1 is built.

Ryan/Francesco, are there particular preferences either way from a relman/l10n perspective?

Flags: needinfo?(ryanvm)
Flags: needinfo?(francesco.lodolo)
Assignee: nobody → gijskruitbosch+bugs
Severity: -- → S2
Status: NEW → ASSIGNED
Priority: -- → P1

I have a slight preference to backing out now and re-landing after the version bump if only because I'm worried about forgetting to do the backout prior to building b1 otherwise.

Flags: needinfo?(ryanvm)

I would rule out backing out the patch as a whole, because we're going to lose all existing translations (and we already have a lot of them).

Is the issue only for the Settings part? Could we have a patch that reverts only that change, but without removing the file from FTL? That way, we can only reintroduce the code change in fx88, without losing any translation.

Flags: needinfo?(francesco.lodolo)

(In reply to Francesco Lodolo [:flod] from comment #2)

I would rule out backing out the patch as a whole, because we're going to lose all existing translations (and we already have a lot of them).

Is the issue only for the Settings part? Could we have a patch that reverts only that change, but without removing the file from FTL? That way, we can only reintroduce the code change in fx88, without losing any translation.

I was planning on only reverting markup changes in the menus relating to the settings/preferences/options change. I don't think there's any FTL files that were added/removed. Am I missing something?

Flags: needinfo?(francesco.lodolo)

I was planning on only reverting markup changes in the menus relating to the settings/preferences/options change. I don't think there's any FTL files that were added/removed. Am I missing something?

When you wrote "back it out", I assumed you meant the whole patch that landed in that bug
https://hg.mozilla.org/mozilla-central/rev/79e9fa618141

Even if this is only about the Settings/Preferences thing, the patch introduces a new string for the Settings menu

menu-settings =
    .label = Settings
    .accesskey =
         { PLATFORM() ->
            [windows] S
            *[other] n
         }

So, I'd be OK with a patch that adds back menu-preferences as it was, and revert changes to browser-menubar.inc, but keep around the new menu-settings.

Flags: needinfo?(francesco.lodolo)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f7e6c28a8060
only change labels for preferences/options/settings in later builds, r=mconley,flod,fluent-reviewers
Whiteboard: [proton-hamburger-menu]
Blocks: 1698678
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.