1698675 - Change cZ gif statusbar and menu icons to png and remove 16x10 icon.

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Frank-Rainer Grahl (:frg)]

buc tracked down a possible performance problem with to 16x.10 gif icon. Gif icons will be replaced overtime with later formats so let take the opportunity to do this here first for the statusbar and menu bar icon.
The status bar icon also is 16x10 and can just be the same as the 16x16 menu bar icon.

Trivial fix so can go into 2.53.7 final release.

+++ snip +++

A broken choice of chatzilla's taskbar icon leads to a constant redrawing of the screen.

Disable ALL the extensions (chatzilla, inspector, lightning) in about:addons, and run SeaMonkey from cmdline with debug:

MOZ_LOG="nsRefreshDriver:5" seamonkey

The debug output stopped after the page is completed, until you move mouse etc., then it stopped again etc.etc It is an expected behaviour.

Then enable chatzilla in about:addons and repeat the MOZ_LOG run.

After the page is completed, the debug output still present infinitely, despite you do nothing.

The problem is suite/extensions/irc/xul/skin/images/taskbar-irc.gif icon, with size 16x10 .
It seems the code require geometry of 16x16 in this area. If you try to use png or jpg icon with another size there, it just not appear. But in the case of gif, the icon with the size of 16x10 (instead of 16x16) still appear, with a side effect of permanent refreshing of the screen (according to the debug output).

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1698675-fixircrefresh-2537.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Possible performance problem. Logs shows continuous refresh activity.
Testing completed (on m-c, etc.): 2.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9209285 [details] [diff] [review]
1698675-fixircrefresh-2537.patch

[Triage Comment]
LGTM r/a=me

Comment 3

[Dmitry Butskoy (:buc)]

The mentioned taskbar-irc.gif icon has oddities.

The output of "identify -verbose taskbar-irc.gif" shows non-empty "Delay" field, whereas the image itself is not animated:

...
  Page geometry: 16x10+0+0
  Dispose: Undefined
  Delay: 10x100
  Duration: 10
  Compression: LZW
...

Seeing a non-zero delay, Mozilla code (up to the current Fx one) assumes that this is an animated image, even if it has only one frame.

If you test with the current Firefox like:

 "MOZ_LOG="nsRefreshDriver:5" firefox file:///path/to/image/taskbar-irc.gif

you will see the same effect. A visually non-animated image technically behaves like a one-frame animated image...

Probably when the animation status is set, additionally to non-zero delay_time it should test the number of frames too...

Normally, utilities which create gifs should not set non-zero delay for actually one-frame non-animated images. All but gimp.

Gimp for some strange reasons always insert a 100ms delay for any exported image in the gif format. It could explain why some gifs in Mozilla and Suite code appears such a way broken.

The file attached below has a list of all one-frame gif images with the delay set.

Comment 4

[Dmitry Butskoy (:buc)]

Attachment: strange-gifs.txt

All with "10x100" is most likely a broken gimp export.

No idea what are 20x100 and even 1000x100 though...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c759af0f983
Convert irc taskbar and statusbarpanel to a 16x16 png. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/35c82b237bf375ff55d76b80056db5ae3b71b8e8
Convert irc taskbar and statusbarpanel to a 16x16 png. r=IanN a=IanN