1699322 - Convert gif icons in SeaMonkey themes to png.

Status: RESOLVED FIXED

(SeaMonkey :: Themes, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1698675 +++

According to the list buc provided in Bug 1698675 some of our gif icons might cause performance or other problems. Firefox and Thunderbird switched to png and svg in latest release. We still have a mix of gif and png icons and should consolidate this for uniformity.

buc tracked down a possible performance problem with to 16x.10 gif icon. Gif icons will be replaced overtime with later formats so let take the opportunity to do this here first for the statusbar and menu bar icon.
The status bar icon also is 16x10 and can just be the same as the 16x16 menu bar icon.

Trivial fix so can go into 2.53.7 final release.

+++ snip +++

A broken choice of chatzilla's taskbar icon leads to a constant redrawing of the screen.

Disable ALL the extensions (chatzilla, inspector, lightning) in about:addons, and run SeaMonkey from cmdline with debug:

MOZ_LOG="nsRefreshDriver:5" seamonkey

The debug output stopped after the page is completed, until you move mouse etc., then it stopped again etc.etc It is an expected behaviour.

Then enable chatzilla in about:addons and repeat the MOZ_LOG run.

After the page is completed, the debug output still present infinitely, despite you do nothing.

The problem is suite/extensions/irc/xul/skin/images/taskbar-irc.gif icon, with size 16x10 .
It seems the code require geometry of 16x16 in this area. If you try to use png or jpg icon with another size there, it just not appear. But in the case of gif, the icon with the size of 16x10 (instead of 16x16) still appear, with a side effect of permanent refreshing of the screen (according to the debug output).

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-1-gif2png-2538.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: The world will end
Testing completed (on m-c, etc.): 2.53.8b1 pre modern and classic
Risk to taking this patch (and alternatives if risky): trivial conversion
String changes made by this patch: --

This adds about 500K to the installer. Most of the smaller icons almost double in size. Some of the bigger ones shrink but not enough of them in the tree to offset the gain.

Patch applied at the end of the current patch chain. Bug 1296850 need to be moved after it.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-2-gif2png-2538.patch

css and packaging changes. duplicate list goes into another patch.

find . -name ".css" | xargs sed -i -e '/communicator/s/.gif/.png/'
find . -name ".css" | xargs sed -i -e '/messenger/s/.gif/.png/'
find . -name ".css" | xargs sed -i -e '/editor/s/.gif/.png/'
find . -name ".css" | xargs sed -i -e '/navigator/s/.gif/.png/'

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: The world has already ended with patch 1 so no impact.
Testing completed (on m-c, etc.): 3.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial replacement.
String changes made by this patch: --

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-3-gif2png-2538.patch

[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: none warning only
Testing completed (on m-c, etc.): 2.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial. We use the -w flag which makes this non-fatal
String changes made by this patch: --

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-domi-gif2png-2538.patch

Do the same for DOMi. No longer has a separate component so just add to this bug. 2.53.branch only.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: unfinished business
Testing completed (on m-c, etc.): 2.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-3-gif2png-2538.patch

[Approval Request Comment]
Regression caused by (bug #): various
User impact if declined: none warning only
Testing completed (on m-c, etc.): 2.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial. We use the -w flag which makes this non-fatal
String changes made by this patch: --

Comment 6

[Dmitry Butskoy (:buc)]

(In reply to Frank-Rainer Grahl (:frg) from comment #0)

buc tracked down a possible performance problem with to 16x0 gif icon.

Nope.
A performance problem with any size gif icon with non-zero delay set (as seems normally produced by gimp).

This adds about 500K to the installer. Most of the smaller icons almost double in size.

It is strange a bit...

My tests on small gif icons (fe. chatzilla-16.gif) shows the size increased about 35% (1.35 < 2.0). I used gimp for conversions.

Maybe there are some stuff -- internal comments etc. -- which can be omitted in the result images?

The cost of additional 500k with no user visible effect should be avoided if possible...

Comment 7

[Dmitry Butskoy (:buc)]

If ImageMagick was used for gif2png conversion, then by default it increases the size up to twice. But if you use "-strip" option (removes mostly some text comments in the file), then the resulting png size is increased about 10% only.

IOW, "convert filename.gif -strip filename.png"

Comment 8

[Frank-Rainer Grahl (:frg)]

I used RWPaint and stripped the extras. Didn't notice first that it were that many files but when I realized it was faster to convert the remaining ones manually. Most files are really tiny and I didn't see bloat in them afterwards. Size increase is only about 200K with a fresh build. It is 2021 so not care much about this imho tiny overall increase.

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-1-gif2png-v1_1-2538.patch

Add back global gifs to the modern theme for compatibility with toolkit css. Let it bake a day or two before asking for review again.

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-2-gif2png-v1_1-2538.patch

Switch "global" gifs in modern to png.

In modern only: find . -name "*.css" | xargs sed -i -e '/global/s/.gif/.png/'

Comment 12

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-3-gif2png-v1_2-2538.patch

Add section for compatibility gif files

Comment 13

[Ian Neal]

Comment on attachment 9209933 [details] [diff] [review]
1699322-domi-gif2png-2538.patch

Isn't 2.0.17.3 sufficient as a bump?

r/a=me either way

Comment 14

[[e-mail]]

Last time I converted images from GIF to PNG I ran them through optipng which does a good basic job of optimising images, but there's also advpng and deflopt if you want to get really serious.

Comment 15

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-1-gif2png-v1_2-2538.patch

Compared the pngs buc provided and the ones I did. Was not 100% one sided so took only the smaller ones. Fixed up the gifs kept for compatibility which had a delay in according to buc also.

For the gifs PMView Pro produced the smallest ones.

Didn't try the tools neil used yet but most pngs are so small it would imho not matter. Might be worth to check it out for the larger ones later.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: The world will end again
Testing completed (on m-c, etc.): 2.53.8b1 pre modern and classic
Risk to taking this patch (and alternatives if risky): trivial conversion
String changes made by this patch: --

Comment 16

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210292 [details] [diff] [review]
1699322-2-gif2png-v1_1-2538.patch

Unchanged
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: The world has already ended with patch 1 so no impact.
Testing completed (on m-c, etc.): 3.53.8b1 pre
Risk to taking this patch (and alternatives if risky): trivial replacement.
String changes made by this patch: --

Comment 17

[Frank-Rainer Grahl (:frg)]

Attachment: 1699322-4-gif2png-v1_1-2538.patch

Patch update for change of DOMI location to suite/extensions/inspector.

Removed the install.rdf version changes. Unrelated to this bug and we can clean it up in a new DOMi bug after the 2.53 integration now in effect.

Kept 2.18 version. Unlikely that this will rollover ever.

r/a+ from IanN retained.

Comment 18

[Ian Neal]

Comment on attachment 9210292 [details] [diff] [review]
1699322-2-gif2png-v1_1-2538.patch

[Triage Comment]
LGTM r/a=me

Comment 19

[Ian Neal]

Comment on attachment 9210743 [details] [diff] [review]
1699322-1-gif2png-v1_2-2538.patch

[Triage Comment]
follow-up can be with optipng r/a=me

Comment 20

[Ian Neal]

Attachment: 1699322-5-modern-optipng-2538.patch

Modern png files run through optipng

Comment 21

[Ian Neal]

Attachment: 1699322-6-classic-optipng-2538.patch

Classic png files run through optipng

Comment 22

[Ian Neal]

Attachment: 1699322-7-extensions-optipng-2538.patch

png files under suite/extensions run through optipng

Comment 23

[Ian Neal]

Attachment: 1699322-8-editor-optipng-2538.patch

editor png files run through optipng

Comment 24

[Ian Neal]

Attachment: 1699322-9-help-optipng-2538.patch

help png files run through optipng

Comment 25

[Ian Neal]

Attachment: 1699322-10-branding-optipng-2538.patch

branding png files run through optipng

Comment 26

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210895 [details] [diff] [review]
1699322-5-modern-optipng-2538.patch

LGTM

Comment 27

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210896 [details] [diff] [review]
1699322-6-classic-optipng-2538.patch

LGTM

Comment 28

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210897 [details] [diff] [review]
1699322-7-extensions-optipng-2538.patch

LGTM
The inspector parts need to be stripped for ESR60 and comm-central.

Comment 29

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210899 [details] [diff] [review]
1699322-8-editor-optipng-2538.patch

LGTM

Comment 30

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210901 [details] [diff] [review]
1699322-9-help-optipng-2538.patch

LGTM

Comment 31

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9211996 [details] [diff] [review]
1699322-10-branding-optipng-2538.patch

LGTM

Picks up some images from Bug 1362210 which I moved into the patch there and will be stripped for checkin.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea59c0e23cfe
Part 1: convert suite gif icons to png. r=IanN
https://hg.mozilla.org/comm-central/rev/8a29fe88a336
Part 2: change gif icons to png in package and css files. r=IanN
https://hg.mozilla.org/comm-central/rev/a1779e29b94e
Part3: Adjust allowed-dupes for latest changes. r=IanN
https://hg.mozilla.org/comm-central/rev/08c5a007d50e
Convert gif icons in SeaMonkey themes to png - modern png run through optipng. r=frg
https://hg.mozilla.org/comm-central/rev/914d6556a09b
Convert gif icons in SeaMonkey themes to png - classic png run through optipng. r=frg
https://hg.mozilla.org/comm-central/rev/27387277f0ac
Convert gif icons in SeaMonkey themes to png - extensions png run through optipng. r=frg
https://hg.mozilla.org/comm-central/rev/94f6b23dd842
Convert gif icons in SeaMonkey themes to png - editor png run through optipng. r=frg
https://hg.mozilla.org/comm-central/rev/f079347a04ce
Convert gif icons in SeaMonkey themes to png - help png run through optipng. r=frg
https://hg.mozilla.org/comm-central/rev/82ff688e3b1a
Convert gif icons in SeaMonkey themes to png - branding run through optipng. r=frg

Comment 33

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/907683a9b0486249eb7f805b701d00ee57238481
Part 1: convert suite gif icons to png. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/483e047d5f8c5453e66a512e6ed79e842c667ee9
Part 2: change gif icons to png in package and css files. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/3ce8dcdb8b5d9f3791fbb0350dc281c799d3f1dd
Part 3: Adjust allowed-dupes for latest changes. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/195105bfff52ce675ae61236016a7bb4bf9c6300
Part 4: Convert DOMi gif icons to png. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1bf8fcd05f39fcbaf1d2d4f69ec199b40482673c
Part 5: Convert gif icons in SeaMonkey themes to png - modern png run through optipng. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/bb7f2ddb0b4f0a59daf0c5ea25450472cac2c66b
Part 6: Convert gif icons in SeaMonkey themes to png - classic png run through optipng. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/07732b795153cf05428e5d42742d5a646414e34a
Part 7: Convert gif icons in SeaMonkey themes to png - extensions png run through optipng. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/919cb7da2286407e72380d74a44359cae9d8db25
Part 8: Convert gif icons in SeaMonkey themes to png - editor png run through optipng. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/de356a05b7b3b65e97e35414fb4df82af05f6829
Part 9: Convert gif icons in SeaMonkey themes to png - help png run through optipng. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8479a34283ef72c8cbe8128ace4f1682400f8239
Part 10: Convert gif icons in SeaMonkey themes to png - branding run through optipng. r=frg a=frg