Closed Bug 1698756 Opened 5 years ago Closed 5 years ago

[macOS] Make Import Wizard look good in dark mode

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Platform:
Unspecified
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mbalfanz, Assigned: ntim)

References

Details

(Whiteboard: [mac:darkmode])

Attachments

(2 files)

Screenshot 2021-03-16 at 11.13.07.png
290.76 KB, image/png
Details
Bug 1698756 - Stop setting black color on .wizard-header-box-1 for macOS. r=mstange,harry
48 bytes, text/x-phabricator-request
Details | Review

With the patch from bug 1697331, and widget.macos.respect-system-appearance set to true, the "Import Wizard" dialog looks like in the attached screenshot in macOS Dark Mode.

The problems I see are:

  • Headline text is black
Summary: Make page info dialog look good in dark mode → Make Import Wizard look good in dark mode
No longer depends on: 1698754
Assignee: nobody → ntim.bugs
Component: Widget: Cocoa → Themes
Product: Core → Toolkit
Attachment #9210515 - Attachment description: Bug 1698756 - Stop setting black color on .wizard-header-box-1. r=mstange,harry → Bug 1698756 - Stop setting black color on .wizard-header-box-1 for macOS. r=mstange,harry
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7098200d66ec Stop setting black color on .wizard-header-box-1 for macOS. r=mstange

https://hg.mozilla.org/mozilla-central/rev/7098200d66ec

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
OS: Unspecified → macOS
Summary: Make Import Wizard look good in dark mode → [macOS] Make Import Wizard look good in dark mode
QA Whiteboard: [qa-88b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: