1698759 - Make bookmarks menu look good in dark mode

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.16.08.png

With the patch from bug 1697331, and widget.macos.respect-system-appearance set to true, the "Create Bookmark" dialog looks like in the attached screenshot in macOS Dark Mode.

The problems I see are:

• Input fields have a light background and light text, e.g. when adding a new folder

Comment 1

[Tim Nguyen :ntim]

FieldText CSS color follows dark mode and returns white, but Field does not and also returns white.

Sounds like Field should return a dark color in this case.

Comment 2

[Markus Stange [:mstange]]

Maybe controlBackgroundColor would be a good match for Field.

Comment 3

[Harry Twyford]

Attachment: Bug 1698759 - Set Field and MozCombobox to colorControlBackground. r?#mac-reviewers

Changing MozCombobox isn't necessary to resolve the bug, but it has the same issue as Field: its text is set to controlTextColor but its background is hardcoded to white.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa3cd3ca2e4f
Set Field and MozCombobox to colorControlBackground. r=mac-reviewers,mstange

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fa3cd3ca2e4f