1700022 - Stop caching duplicate colors

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

LookAndFeel.mm caches some system colors in multiple variables with different names. I think it would be better to cache each system color only once and then use the same cached variable for different CSS color names.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1700022 - Remove mColorButtonText member because it's always white. r=#mac-reviewers

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1700022 - Only store [NSColor alternateSelectedControlTextColor] once. r=#mac-reviewers

Depends on D109252

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1700022 - Only cache [NSColor controlTextColor] once. r=#mac-reviewers

Depends on D109253

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1700022 - Only cache [NSColor gridColor] once. r=#mac-reviewers

Depends on D109254

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1700022 - Only cache [NSColor controlBackgroundColor] once. r=#mac-reviewers

Depends on D109255

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e90b0f20f535
Remove mColorButtonText member because it's always white. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/3f3519e0995c
Only store [NSColor alternateSelectedControlTextColor] once. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/932cf28e6f9f
Only cache [NSColor controlTextColor] once. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/2eb56f7c1f37
Only cache [NSColor gridColor] once. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/ad76834e7e61
Only cache [NSColor controlBackgroundColor] once. r=mac-reviewers,bradwerth

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e90b0f20f535
https://hg.mozilla.org/mozilla-central/rev/3f3519e0995c
https://hg.mozilla.org/mozilla-central/rev/932cf28e6f9f
https://hg.mozilla.org/mozilla-central/rev/2eb56f7c1f37
https://hg.mozilla.org/mozilla-central/rev/ad76834e7e61