1698783 - Firefox Nightly 88.0a1 (2021-03-16) stopped respecting system scrollbar width

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[[e-mail]]

Attachment: Firefox nightly 88.0a1 (2021-03-01) scrollbar width.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Screenshots attached

Actual results:

Screenshots attached

Expected results:

Screenshots attached

Comment 1

[[e-mail]]

Attachment: Firefox nightly 88.0a1 (2021-03-16) scrollbar width.png

Comment 2

[Andrei Purice]

Unfortunately I am not able to reproduce this issue on my device but it clearly worked fine for you on a previous Nightly version. Could you please try to find the regressor of this issue by using our Mozzregression tool? Here is how to do that: https://mozilla.github.io/mozregression/.

Comment 3

[[e-mail]]

(In reply to Andrei Purice from comment #2)

Unfortunately I am not able to reproduce this issue on my device but it clearly worked fine for you on a previous Nightly version. Could you please try to find the regressor of this issue by using our Mozzregression tool? Here is how to do that: https://mozilla.github.io/mozregression/.

Hello, Andrei

https://hg.mozilla.org/mozilla-central/rev/e2e3769604efd9724670ca1474377789e003a992

i think this is it - non-native theme

Comment 4

[[e-mail]]

when i set "widget.non-native-theme.enabled" = false, all is ok again
but when i'm trying to change widget.non-native-theme.gtk.scrollbar.normal-size for example to 30 or 40 - there is no reaction

and of course, i did all this with a restart

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to [e-mail] from comment #4)

when i set "widget.non-native-theme.enabled" = false, all is ok again
but when i'm trying to change widget.non-native-theme.gtk.scrollbar.normal-size for example to 30 or 40 - there is no reaction

Well, those prefs have gtk in the name because they're Linux-specific. But we could add some for Windows I guess, or try to respect the system settings.

Do you know how to change the scrollbar sizes on Windows? You need to tweak the registry like this right? (As in, it's not exposed in the UI for most users)

Comment 6

[[e-mail]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

(In reply to [e-mail] from comment #4)

when i set "widget.non-native-theme.enabled" = false, all is ok again
but when i'm trying to change widget.non-native-theme.gtk.scrollbar.normal-size for example to 30 or 40 - there is no reaction

Well, those prefs have gtk in the name because they're Linux-specific. But we could add some for Windows I guess, or try to respect the system settings.

Do you know how to change the scrollbar sizes on Windows? You need to tweak the registry like this right? (As in, it's not exposed in the UI for most users)

Yes, this is correct for Windows 10.
But in Windows 7 and 8 these settings presents in the GUI.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698783 - Make non-native scrollbar size configurable in Windows too. r=mstange

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698783 - Respect Windows' system scrollbar sizes. r=mstange

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e680b4d92b1
Make non-native scrollbar size configurable in Windows too. r=mstange
https://hg.mozilla.org/integration/autoland/rev/a96c49a026f6
Respect Windows' system scrollbar sizes. r=mstange

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8e680b4d92b1
https://hg.mozilla.org/mozilla-central/rev/a96c49a026f6