Context menus are missing block padding (need 4px spacing at the top and bottom between first/last visible item and the edge of the menu)
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | verified |
People
(Reporter: mstriemer, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-context-menus])
Attachments
(1 file)
|
69.28 KB,
image/png
|
Details |
Screen Shot 2021-03-16 at 9.48.18 AM.png
The context menu is supposed to have 4px of block padding. So items are flush next to each other but the top/bottom items should have the 4px of space from the edge of the context menu.
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
I'm fixing this in bug 1699427, because for the new styling I needed to change submenu positioning anyway, which is also affected by this change (because it changes spacing between the top of the menu and the top of the first item, which we want to align to the hovered/selected item in the parent menu).
|
||
Comment 3•3 years ago
|
||
Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Fixed by bug 1699427.
|
||
Comment 5•3 years ago
|
||
Verified that after the fix from bug 1699427 there is a spacing above and below for first and last label inside context menus using latest Nightly 88.0a1.
Description
•