1698834 - Fix urlbar zoom indicator

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Tim Nguyen :ntim]

Attachment: image.png

This looks broken both with proton and non-proton.

Comment 1

[Tim Nguyen :ntim]

Mak/Harry, is this related to the recent padding changes? This seems to affect non-proton too.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It's likely, yes.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=07175f03c6589b38923fa7958525fdb133dbe2de&tochange=9c4b24df327f1fa0a37ca783bbec57d6bd9141f3

Comment 4

[Tim Nguyen :ntim]

Thanks Alice0775!

This seems to be due to the removed:

#page-action-buttons {
  -moz-box-align: center;
}

Though I think this bug should rather focus on redesigning the styles.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Tim Nguyen :ntim from comment #4)

This seems to be due to the removed:

#page-action-buttons {
  -moz-box-align: center;
}

yes, the problem is that such rule in hidpi is causing pixel rounding out of Proton that looks wrong (there is space either above or below page action buttons, while instead they should touch the border)

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1697801

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1698834 - Fix urlbar zoom indicator style (both for Proton and not). r=ntim,harry

Fix the margins on the zoom indicator, so that it's as tall as other icons.
Style the zoom indicator as an urlbar chiclet in Proton.
Add hover and active states to the zoom indicator and the identity-box in Proton.
Fix the center alignment of the cfr label.

Comment 9

[Romain Testard [:RT]]

Marking as P2. Per experience review we agreed to mark as P1 bugs only bugs that will block MR1.

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Just fyi, this regression also affects non-proton.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25186df80cfa
Fix urlbar zoom indicator style (both for Proton and not). r=harry

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 25186df80cfa (bug 1698834) for browser_preferences_usage.js mochitest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=E7ZohIkpTaea2SjzuPsXDA.0&fromchange=899eda4ec42644e0d04182334b4e79c74d9f8d04&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fperformance&tochange=05dbdc65a0da4889b4675986e80d0ed9ddf5b821

Backout link: https://hg.mozilla.org/integration/autoland/rev/05dbdc65a0da4889b4675986e80d0ed9ddf5b821

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333795724&repo=autoland&lineNumber=1667

[task 2021-03-19T16:30:20.859Z] 16:30:20     INFO - TEST-START | browser/base/content/test/performance/browser_preferences_usage.js
[task 2021-03-19T16:30:20.885Z] 16:30:20     INFO - TEST-INFO | started process screencapture
[task 2021-03-19T16:30:20.996Z] 16:30:20     INFO - TEST-INFO | screencapture: exit 0
[task 2021-03-19T16:30:20.996Z] 16:30:20     INFO - Buffered messages logged at 16:30:20
[task 2021-03-19T16:30:20.996Z] 16:30:20     INFO - Entering test bound debug_only
[task 2021-03-19T16:30:20.997Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | You need to run this test on a debug build. - 
[task 2021-03-19T16:30:20.997Z] 16:30:20     INFO - Leaving test bound debug_only
[task 2021-03-19T16:30:20.997Z] 16:30:20     INFO - Entering test bound startup
[task 2021-03-19T16:30:20.997Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | startupRecorder has prefStats - 
[task 2021-03-19T16:30:20.997Z] 16:30:20     INFO - network.loadinfo.skip_type_assertion should not be accessed more than 40 times and was accessed 877 times.
[task 2021-03-19T16:30:20.998Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.startup.record should be accessed at least 200 times. - 200 <= 326 - 
[task 2021-03-19T16:30:20.998Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.startup.record should be accessed at most 350 times. - 326 <= 350 - 
[task 2021-03-19T16:30:20.998Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.proton.enabled should be accessed at most 100 times. - 68 <= 100 - 
[task 2021-03-19T16:30:20.998Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.css.dpi should be accessed at least 45 times. - 45 <= 55 - 
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.css.dpi should be accessed at most 81 times. - 55 <= 81 - 
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - Buffered messages finished
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | browser.proton.urlbar.enabled should not be accessed more than 40 times. - 41 <= 40 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 42
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - Stack trace:
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:42
[task 2021-03-19T16:30:20.999Z] 16:30:20     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:startup:138
[task 2021-03-19T16:30:21.000Z] 16:30:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.proton.tabs.enabled should not be accessed more than 40 times. - 32 <= 40 - 
[task 2021-03-19T16:30:21.000Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | extensions.webextensions.uuids should not be accessed more than 40 times. - 31 <= 40 - 
[task 2021-03-19T16:30:21.000Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | extensions.webextensions.base-content-security-policy should not be accessed more than 40 times. - 26 <= 40 - 
[task 2021-03-19T16:30:21.000Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | bidi.numeral should not be accessed more than 40 times. - 22 <= 40 - 
[task 2021-03-19T16:30:21.000Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.throttled_frame_rate should not be accessed more than 40 times. - 22 <= 40 - 
[task 2021-03-19T16:30:21.001Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | image.animation_mode should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.001Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.scrollbar.side should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.001Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.display.auto_quality_min_font_size should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.001Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.reflow.showframecounts should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.002Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.reflow.dumpframebyframecounts should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.002Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | bidi.direction should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.002Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | bidi.texttype should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.002Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.reflow.dumpframecounts should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.002Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | gfx.missing_fonts.notify should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.004Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.visibility.min-recompute-interval-ms should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.004Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | dom.send_after_paint_to_content should not be accessed more than 40 times. - 21 <= 40 - 
[task 2021-03-19T16:30:21.004Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | chrome.override_package.global should be accessed at most 50 times. - 20 <= 50 - 
[task 2021-03-19T16:30:21.007Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | nglayout.initialpaint.delay should not be accessed more than 40 times. - 19 <= 40 - 
[task 2021-03-19T16:30:21.007Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | intl.accept_languages should not be accessed more than 40 times. - 15 <= 40 - 
[task 2021-03-19T16:30:21.008Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | nglayout.debug.paint_flashing should not be accessed more than 40 times. - 15 <= 40 - 
[task 2021-03-19T16:30:21.008Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | dom.fileHandle.enabled should not be accessed more than 40 times. - 14 <= 40 - 
[task 2021-03-19T16:30:21.008Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | intl.l10n.pseudo should not be accessed more than 40 times. - 14 <= 40 - 
[task 2021-03-19T16:30:21.008Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | services.settings.default_bucket should not be accessed more than 40 times. - 14 <= 40 - 
[task 2021-03-19T16:30:21.009Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | permissions.default.geo should not be accessed more than 40 times. - 13 <= 40 - 
[task 2021-03-19T16:30:21.009Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.privatebrowsing.autostart should not be accessed more than 40 times. - 13 <= 40 - 
[task 2021-03-19T16:30:21.009Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | bidi.browser.ui should not be accessed more than 40 times. - 13 <= 40 - 
[task 2021-03-19T16:30:21.009Z] 16:30:21     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.css.prefixes.columns should not be accessed more than 40 times. - 11 <= 40 - 
...
...
...

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It looks like we just hit https://bugzilla.mozilla.org/show_bug.cgi?id=1698132, I'll just add an exception until we merge to the main proton pref.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddd4933af39e
Fix urlbar zoom indicator style (both for Proton and not). r=harry

Comment 15

[Amy Lee [:amylee] UX]

Hi,

Here is the design for the zoom state in proton. Please scroll down to the bottom of spec.

https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-Mozilla-Confidential?node-id=1729%3A66576

Comment 16

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2021-03-19 at 3.32.46 PM.png

Showing screenshot of figma file for reference of new zoom asset in Proton

Comment 17

[Tim Nguyen :ntim]

ni? Marco/Harry for visibility. ^

Comment 18

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I'll file a bug to fix the few differences, without the spec I got pretty close, but there's a few differences to fix.

Comment 19

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ddd4933af39e