169885 - Remove evidence of CLOSED from bugzilla.mozilla.org

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://bugzilla.mozilla.org/bug_status.html contains a description for the
CLOSED status,which makes it sound like it should be used on b.m.o.

however, bmo's policy is to not use that status. that document should be changed
to reflect this.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

same probably goes for LATER and REMIND on that page.

Comment 2

[Sören 'Chucker' Kuklau (gone)]

It may also be a good idea to remove the "Close bug" radio button from the
templates on this bugzilla installation. They only cause confusion, especially
for users of Chimera, it seems.

Comment 3

[Gervase Markham [:gerv]]

I think that if, as Asa said recently, mozilla.org has no use for CLOSED, then
we should remove the option from b.m.o. 

This would be as simple as a couple of [% NEXT IF status == "CLOSED" %] in some
loops in the bug display and query templates.

myk, asa: views?

Gerv

Comment 4

[Michael Lefevre]

for the record, if this is going to happen, then www.mozilla.org/bugs should be
updated as well...

Comment 5

[Gervase Markham [:gerv]]

Asa said:

"If it's not a lot of work. sure. I wouldn't spend any time on it that could go
to fixing real bugs but if someone's gonna do the work I'll certainly take it."

Gerv

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: suggested patch for bug_status.html

This patch removes the CLOSED status frpm
http://bugzilla.mozilla.org/bug_status.html

it would also be a good idea to remove the "mark bug CLOSED" radiobutton from
show_bug.cgi.

Comment 7

[Gervase Markham [:gerv]]

Er... the latter of those two things is the important one, rather than the
former :-)

Gerv

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Gerv: well, I don't think the templates used by bmo are publically accessible
(or are they identical to the bugzilla 2.17.1 release?)


if you send them to me, I can try to make a patch

Comment 9

[Dave Miller [:justdave]]

The only custom templates bugzilla.mozilla.org has are the index page, and the
per-product enter_bug messages.  Patches against the core Bugzilla to accomplish
this would likely work.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch against bugzilla templates

well, it seems to be as simple as this

Comment 11

[Gervase Markham [:gerv]]

Yep, it's that simple. Don't you love templates? :-)

Reassigning to Myk for application of these two patches to b.m.o.

Gerv

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

er, wait, the second part (the edit-multiple part) does not work, please ignore
it for now.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: working patch against templates

Arg... I shouldn't have deleted the [% END %]...

Anyway, this patch works now on my local installation.

Comment 14

[Simon Paquet [:sipaq]]

Is this going in anywhere in the near future. It's quite painful to always
reopen, re-resolve and verify the bugs, that people closed, because they didn't
know that CLOSED is deprecated.

And if we do this, we should also think about erasing the remaining CLOSED bugs,
by reoping, re-resolving and verifying them. At the moment we have 333
DUPLICATE, 355 FIXED, 363 INVALID, 97 WONTFIX and 392 WORKSFORME bugs which are
CLOSED.

For all but the duplicates the process is very easy. Three mass queries for
every resolution and that's it. Only the duplicates will be hard, because as far
as I know they have to be re-resolved by hand.

Comments?

Comment 15

[Dave Miller [:justdave]]

attachment 121803 [details] [diff] [review] has been applied to b.m.o, and bug_status.html has been
updated to remove the reference to CLOSED, though I didn't use the exact patch
given here (I kept the reference to REOPENED, but move it into the VERIFIED
description).

That doesn't do anything for existing CLOSED bugs.  There's a number of them in
the Bugzilla product that I'd like to remain CLOSED, because they were fake bugs
that were the result of a failed experiment, and I hate having them come up in
queries. :)  Maybe those ones are safe to just delete now...

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

For the remaining CLOSED bugs, maybe someone can do a simple SQL query against
the bugzilla database to change the state to VERIFIED? though that leaves no
trace in the activity logs...

Comment 17

[Derek Schrock]

This page also needed updated for the CLOSED description

Comment 18

[Simon Paquet [:sipaq]]

Dave, it seems that the second part of the patch in this bug (edit-multiple.html.tmpl) that you checked in over to years ago has been overwritten by the standard bugzilla code.

If you try to change multiple bugs at once, you can resolve those as CLOSED. Could you please reapply the patch.

Comment 19

[Gervase Markham [:gerv]]

Reassigning to justdave, as per comment #18.

Gerv

Comment 20

[Reed Loden [:reed]]

(In reply to comment #19)
> Reassigning to justdave, as per comment #18.

Actually following through with reassignment, though I disagree with removing CLOSED. I actually occasionally use it for really annoying bugs on bmo that need to be closed so that they do not show up on the "Hot Bugs" list because they are just extremely common invalid bugs.

Comment 21

[Reed Loden [:reed]]

I have made this change in preparation of BMO's upgrade.

This change will go live Tuesday.