Open Bug 1698881 Opened 3 years ago Updated 1 month ago

Support `audio/aac` for the source buffer

Categories

(Core :: Audio/Video: Playback, task, P3)

task

Tracking

()

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Per the spec, audio/aac is also the one of MSE supported type, and we're able to parse them by ADTSContainerParser and to decode them via platform decoder because it's AAC.

Doing that will also fix these wpt failures [1], which all other browsers pass.

[1]
https://wpt.fyi/results/media-source/mediasource-addsourcebuffer-mode.html?label=master&label=experimental
https://wpt.fyi/results/media-source/mediasource-changetype.html?label=experimental&label=master

Per the spec, audio/aac is also the one of MSE supported type, and we're able to parse them by ADTSContainerParser and to decode them via platform decoder because it's AAC.

How about supporting "audio/mpeg" in https://bugzilla.mozilla.org/show_bug.cgi?id=1169485? :)

If the patents of mp3 has already expired, then I'm glad to see having more supported types, which might decrease the compatible issues. (Chrome and Safari both support audio/aac and audio/mpeg) Bryce, any thought about supporting audio/mpeg? Thanks.

Flags: needinfo?(bvandyk)

It looks like there's a lot going on in that bug, I'll hold the NI and try to parse it all when I have a moment.

Relatedly, I assume given our current decoders we do not have license limitations around mp3, but it's probably worth checking with legal before we undertake any significant technical work just to be sure.

See Also: → 1699249

In order to support playing audio/aac, simply using ADTSContainerParser in our code didn't work, and I got some error in TrackBufferManager. In addition, in bug 1699249, I added some probes to collect the usage of different mime types being used in MSE.

Please file a bug at OpenAI to use Opus, a free and modern codec, instead of the old patented AAC codec.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: