1699000 - s/GetCrossDocParentFrame/GetCrossDocParentFrameInProcess/ in TextOverflow.cpp

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Daniel Holbert [:dholbert]]

Per bug 1698680, we're adding a new wrapper API called GetCrossDocParentFrameInProcess(), and we're migrating existing GetCrossDocParentFrame() calls to use the new function, after checking that they're OK with the fact that it doesn't cross processes for cross-origin content.

I'm filing this bug on doing this for changes in TextOverflow.cpp (which has one such call).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1699000: Use GetCrossDocParentFrameInProcess() in TextOverflow.cpp. r?tnikkel

This patch doesn't change behavior; GetCrossDocParentFrameInProcess() is just a
wrapper for GetCrossDocParentFrame(), which is what we were calling before.

The "InProcess" version of this API (which we're migrating to in this patch) is
used to annotate GetCrossDocParentFrame() callsites that have been vetted as
being OK with the fact that this API returns null at the boundary of a
cross-origin iframe, if fission is enabled.

In this patch, the one call that I'm migrating is inside of
IsFrameDescendantOfAny(), which is a helper-function called by
TextOverflow::PruneDisplayListContents(), which is a function that we use to
traverse a display list and hide content that's been hidden via
"text-overflow:ellipsis" or "-webkit-line-clamp".

We're OK to migrate this call to the "InProcess"-flavored API, because it's
just looking back up the frame tree from the display items that we can reach in
our traversal, which are trivially all part of the same process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af9cc260ae23
Use GetCrossDocParentFrameInProcess() in TextOverflow.cpp. r=tnikkel

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/af9cc260ae23

Comment 4

[Chris Peterson [:cpeterson]]

Setting Fission Milestone to M7a (the current Beta milestone) because this bug is blocking meta bug 1599913 which is a blocker for Fission M7a.