s/GetCrossDocParentFrame/GetCrossDocParentFrameInProcess/ in LocalAccessible.cpp
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file, 1 obsolete file)
Per bug 1698680, we're adding a new wrapper-API called GetCrossDocParentFrameInProcess(), and we're migrating existing GetCrossDocParentFrame() calls to use the new function, after checking that they're OK with the fact that it doesn't cross processes for cross-origin content.
LocalAccessible.cpp has one such call, which we can migrate. Filing this bug on doing so.
|
Assignee | |
Comment 1•3 years ago
|
||
This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)
We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.
In this case in LocalAccessible.cpp, there's an existing code-comment that
indicates that the contextual code already considers & accounts for this
possibility, so it looks like this spot is OK.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)
We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.
The code here, InvalidateImages, is walking up an invalidated image's
ancestor-chain, to invalidate any rendering observers of those ancestors. It's
OK that this walk will stop at the process boundary, because we don't support
rendering observers for cross-origin out-of-process content anyway.
|
||
Comment 3•3 years ago
|
||
Comment on attachment 9209658 [details]
Bug 1699029: Switch to use wrapper-API GetCrossDocParentFrameInProcess() in ImageLoader.cpp. r?tnikkel
Revision D108739 was moved to bug 1699031. Setting attachment 9209658 [details] to obsolete.
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dbec71e0b743 Switch to use wrapper-API GetCrossDocParentFrameInProcess() in LocalAccessible::VisibilityState(). r=hiro
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Comment 6•3 years ago
|
||
Setting Fission Milestone to M7a (the current Beta milestone) because this bug is blocking meta bug 1599913 which is a blocker for Fission M7a.
Description
•