1699041 - Verify the error handling of `SpinEventLoopUntilOrQuit` during shutdown

Status: NEW

(Core :: XPCOM, task)

Description

[Jens Stutte [:jstutte]]

Verify the error handling of SpinEventLoopUntilOrQuit during shutdown (currently we just return NS_OK). We could distinct the case "called before shutdown has started" from the case "calling during shutdown", the latter is probably unwanted (think of some JS code triggered by a shutdown observer). This might need some cleanup on JS side, too. Or we might just want to add some assertions.

Comment 1

[Jens Stutte [:jstutte]]

There is a similar case in AppWindow::ShowModal (C++).

Comment 2

[Jens Stutte [:jstutte]]

An argument for always returning an error might also be that this hopefully speeds up any script processing we have on the stack while this happens (throwing an exception) rather than trying to do something meaningful with the never set result of a modal dialog. FWIW: Also in the C++ case seen in the wild we come from JS on the stack.