Closed Bug 1699088 Opened 3 years ago Closed 3 years ago

Cache fonts / floats / ints in nsXPLookAndFeel.

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
89 Branch

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: perf-alert)

Attachments

(4 files)

This allows to simplify nsLookAndFeel implementations, particularly windows'.

No reason this needs to be declared in the header.

We'll use this for more stuff.

Depends on D108763

And make FontID's indexing setup more similar to FloatID / IntID / ColorID. The
values no longer need to match the style constants since Stylo. We could also
cache whether the lookup succeeded for floats / ints, but it might not be worth
it, your call though.

Depends on D108764

Follow the pattern we use for system colors.

Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3faac915f9cb
Move LookAndFeel color caching and prefs code into nsXPLookAndFeel.cpp. r=cmartin
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cce5976ef31
Make the color cache generic. r=cmartin
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7b40df80335
Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/746b183a820e
Use a single system font definition rather than two. r=cmartin
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/af8ff5e80abb
Fix a test that wasn't waiting for pref changes to actually apply.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

(In reply to Pulsebot from comment #10)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7b40df80335
Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/746b183a820e
Use a single system font definition rather than two. r=cmartin

== Change summary for alert #29442 (as of Fri, 26 Mar 2021 17:23:24 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
4% tresize macosx1015-64-shippable e10s stylo 9.77 -> 9.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29442

Regressions: 1715786
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: