Cache fonts / floats / ints in nsXPLookAndFeel.
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: perf-alert)
Attachments
(4 files)
This allows to simplify nsLookAndFeel implementations, particularly windows'.
Assignee | ||
Comment 1•3 years ago
|
||
No reason this needs to be declared in the header.
Assignee | ||
Comment 2•3 years ago
|
||
We'll use this for more stuff.
Depends on D108763
Assignee | ||
Comment 3•3 years ago
|
||
And make FontID's indexing setup more similar to FloatID / IntID / ColorID. The
values no longer need to match the style constants since Stylo. We could also
cache whether the lookup succeeded for floats / ints, but it might not be worth
it, your call though.
Depends on D108764
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Follow the pattern we use for system colors.
Assignee | ||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3faac915f9cb Move LookAndFeel color caching and prefs code into nsXPLookAndFeel.cpp. r=cmartin
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6cce5976ef31 Make the color cache generic. r=cmartin
Comment 8•3 years ago
|
||
bugherder |
Comment 9•3 years ago
|
||
bugherder |
Comment 10•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7b40df80335 Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin https://hg.mozilla.org/integration/autoland/rev/746b183a820e Use a single system font definition rather than two. r=cmartin
Comment 11•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/af8ff5e80abb Fix a test that wasn't waiting for pref changes to actually apply.
Comment 12•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 13•3 years ago
|
||
(In reply to Pulsebot from comment #10)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7b40df80335
Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/746b183a820e
Use a single system font definition rather than two. r=cmartin
== Change summary for alert #29442 (as of Fri, 26 Mar 2021 17:23:24 GMT) ==
Improvements:
Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|---|
4% | tresize | macosx1015-64-shippable | e10s stylo | 9.77 -> 9.42 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29442
Updated•3 years ago
|
Updated•3 years ago
|
Description
•