1699088 - Cache fonts / floats / ints in nsXPLookAndFeel.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This allows to simplify nsLookAndFeel implementations, particularly windows'.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699088 - Move LookAndFeel color caching and prefs code into nsXPLookAndFeel.cpp. r=cmartin

No reason this needs to be declared in the header.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699088 - Make the color cache generic. r=cmartin

We'll use this for more stuff.

Depends on D108763

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699088 - Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin

And make FontID's indexing setup more similar to FloatID / IntID / ColorID. The
values no longer need to match the style constants since Stylo. We could also
cache whether the lookup succeeded for floats / ints, but it might not be worth
it, your call though.

Depends on D108764

Comment 4

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=5fdecc5ade44214fce27f425824b8dadc7b9a219

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699088 - Use a single system font definition rather than two. r=cmartin

Follow the pattern we use for system colors.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3faac915f9cb
Move LookAndFeel color caching and prefs code into nsXPLookAndFeel.cpp. r=cmartin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cce5976ef31
Make the color cache generic. r=cmartin

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3faac915f9cb

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6cce5976ef31

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b40df80335
Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/746b183a820e
Use a single system font definition rather than two. r=cmartin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af8ff5e80abb
Fix a test that wasn't waiting for pref changes to actually apply.

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e7b40df80335
https://hg.mozilla.org/mozilla-central/rev/746b183a820e
https://hg.mozilla.org/mozilla-central/rev/af8ff5e80abb

Comment 13

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #10)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b40df80335
Cache fonts / floats / ints in nsXPLookAndFeel. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/746b183a820e
Use a single system font definition rather than two. r=cmartin

== Change summary for alert #29442 (as of Fri, 26 Mar 2021 17:23:24 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	tresize		macosx1015-64-shippable	e10s stylo	9.77 -> 9.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29442