Closed Bug 1715786 Opened 4 years ago Closed 4 years ago

ScrollToClick setting does not update when changed

Categories

(Core :: Widget, defect)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox90 --- wontfix
firefox91 --- fixed
firefox92 --- fixed

People

(Reporter: enndeakin, Assigned: mstange)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The bug 1702756 added some caching for LookAndFeel, but some system settings need to be looked up each time.

I only tested a few on Mac but at least the TabFocusModel (keyboard tabbing behaviour) and ScrollToClick (System Preferences -> General -> Click in the scroll bar to) no longer update when the setting is changed and I must exit Firefox to see the changes.

This is most notable with TabFocusModel since I can no longer press Ctrl+F7 to change it.(I found this bug when trying to check 1600430)

Blocks: 1600430

We should observe changes to that setting instead, and call LookAndFeel::NotifyChangedAllWindows presumably with a new change bit that means "no layout or style changed at all".

Component: CSS Parsing and Computation → Widget: Cocoa
Component: Widget: Cocoa → Widget

Let's make this bug about the ScrollToClick pref. If we find other prefs that are affected, we can file new bugs for each of them.

Assignee: nobody → mstange.moz
No longer blocks: 1600430
Status: NEW → ASSIGNED
Summary: Some LookAndFeel settings are incorrectly being cached and not updating when changed → ScrollToClick setting does not update when changed
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/fe2e31f41fd2 Observe dynamic changes to the ScrollToClick system pref. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Is this something we should consider uplifting to 91?

Flags: needinfo?(mstange.moz)

Comment on attachment 9230821 [details]
Bug 1715786 - Observe dynamic changes to the ScrollToClick system pref. r=emilio

Beta/Release Uplift Approval Request

  • User impact if declined: If a scrollbar-related macOS system preference is changed while Firefox is running, the new value is only respected after a Firefox restart.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: 1. In a scrollbar in Firefox, click in the track and check whether it jumps to the clicked position or scrolls one page.
  1. Change the macOS system setting in the General pane.
  2. Repeat step 1 and check if the behavior respects the new setting.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very low, only adds a listener for a system notification.
  • String changes made/needed:
Flags: needinfo?(mstange.moz)
Attachment #9230821 - Flags: approval-mozilla-beta?

Comment on attachment 9230821 [details]
Bug 1715786 - Observe dynamic changes to the ScrollToClick system pref. r=emilio

regression fix, approved for 91 rc1

Attachment #9230821 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

As far as I can tell this patch depends on bug 1600430?

Flags: needinfo?(mstange.moz)
Flags: needinfo?(mstange.moz)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: