1699159 - Shared auto-Cc/Bcc recipients lost when changing an identity during composition (identity1: [e-mail]; identity2: [e-mail], [e-mail]). Works when replying.

Status: NEW

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Andi]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36

Steps to reproduce:

Have an account with more than one identity and set-up with default BCC addresses. For example:
Main identity: BCC these e-mail addresses: [e-mail]
Additional identity: BCC these e-mail addresses: [e-mail]; [e-mail]

I start a new e-mail, and switch to the additional identity.

Actual results:

A BCC is shown only for [e-mail]

Expected results:

The BCC should be shown for [e-mail] and [e-mail]

Notes:

• This was my original discovery of the bug, but there are other similar situations (for example, I recall it also happens with default CCs.
• There isn't a problem when replying to an e-mail sent to the Additional identity: in that case both BCC e-mails will be included.
• I tried different e-mail address separators (eg. comma, space) with no success; but I also note that no guidance or validation seems to be made about separators.

Comment 1

[Andi]

Hello? Anybody home?

Comment 2

[Thomas D. (:thomas8)]

(In reply to Andi from comment #1)

Hello? Anybody home?

Hi Andi, yes, come on inside, sorry, it's just that the house is big as we live here with thousands of bugs, and we're still working on our bilocation skills! ;-)

Confirming exactly as described: When switching identities in From field, an auto-cc/bcc address which is shared between identity1 and identity2 of any account will get lost if identity2 has more than 1 auto-cc/bcc address.

Comment 3

[Thomas D. (:thomas8)]

Gobbling pre-defined auto-Cc/Bcc's is dataloss of sorts.

Comment 4

[Thomas D. (:thomas8)]

I once fixed dataloss issues in this corner in related bug 1623285, but since we've always removed the auto-CC/Bcc's of the previous identity when changing identity (and I've actually made that more accurate/restrictive), I don't think I broke this.

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Thomas D. (:thomas8) from comment #4)

I once fixed dataloss issues in this corner in related bug 1623285, but since we've always removed the auto-CC/Bcc's of the previous identity when changing identity (and I've actually made that more accurate/restrictive), I don't think I broke this.

It think it might have been that patch that caused the regression.

1. Here everything in the BCC field before the identity change is added to toCcBccAddrs https://hg.mozilla.org/comm-central/rev/5384fda06708#l1.151 This includes the auto-BCC of the previous identity.
2. Here every auto-BCC of the previous identity is removed https://hg.mozilla.org/comm-central/rev/5384fda06708#l1.155
3. Here every entry in toCCcBccAddrs is excluded from being added to the new BCC https://hg.mozilla.org/comm-central/rev/5384fda06708#l1.167

As such, any BCC that was in the previous identity is excluded when switching to the new identity.

The current code still does the same thing https://searchfox.org/comm-central/rev/cd3088d72a9a397af39540a47a785e31581a8ccc/mail/components/compose/content/MsgComposeCommands.js#8969-8987

Maybe the intention was to construct toCcBccAddrs after removing prevBcc.

The CC field has the same issue from the same patch.