1699160 - Port bug 1699094: Remove toolkit/themes/*/global/icons/sslWarning.png

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Richard Marti (:Paenglab)]

We use this icon in accountCreation.css.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1699160-remove-sslWarning.png.patch

When you want to test it you need the M-C patch or copy the icon manually to the correct position.

An issue could be that the panel background is #ffffc7 and the warning triangle has #ffe900.
I'll attach a screenshot.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: insecureLarry.png

Comment 3

[Tim Nguyen :ntim]

Note that I'm not planning to land bug 1699094 (the image won't be moved to toolkit), I'll just wait for netError.xhtml removal to clean these up.
You could use one of these:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/icons/connection-mixed-active-loaded.svg
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/icons/connection-mixed-passive-loaded.svg

Otherwise, you could also repackage the cert-error image on your side.

Comment 4

[Richard Marti (:Paenglab)]

Thank you Tim, I'll look with Alessandro what we want to do. As he's on overhauling the account hub this could be done then.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1699160-remove-sslWarning.png.patch

Using connection-mixed-passive-loaded.svg now.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9209789 [details] [diff] [review]
1699160-remove-sslWarning.png.patch

Review of attachment 9209789 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.

Comment 7

[Richard Marti (:Paenglab)]

In bug 1699183 the connection-mixed-passive-loaded.svg will be renamed to security-warning.svg. I'll wait until this lands and update now the patch to the new name.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1699160-remove-sslWarning.png.patch

Updated the patch with the new icon name.

Comment 9

[Richard Marti (:Paenglab)]

Bug 1699183 landed and this patch can land now.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90d12f8e408f
Port bug 1699094: Remove toolkit/themes/*/global/icons/sslWarning.png. r=aleca