1699168 - Document that new metrics need a non-gecko-feature entry in metrics.rs

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik] (Away 2026-08-24 - 2026-08-28)]

To satisfy the linter we need to expose the same symbols in a non-gecko build, we do that in toolkit/components/glean/api/src/metrics.rs, but that was missed for labeled counters.

We should document this as part of the "Adding a New Metric Type" documentation

Comment 1

[Chris H-C :chutten]

We should also document our expectations around running clippy, if we're going to expect folks to keep metrics.rs up-to-date fo rit.

Comment 2

[Chris H-C :chutten]

Weird. ./mach lint --linter clippy toolkit/components/glean/ comes up with 0 errors despite there being no Quantity.

Jan-Erik, is it possible we no longer have to worry about this?

Comment 3

[Jan-Erik Rediger [:janerik] (Away 2026-08-24 - 2026-08-28)]

(In reply to Chris H-C :chutten from comment #2)

Weird. ./mach lint --linter clippy toolkit/components/glean/ comes up with 0 errors despite there being no Quantity.

Jan-Erik, is it possible we no longer have to worry about this?

It requires the full path to the entry of a library, e.g. ./mach lint --linter clippy toolkit/components/glean/api/src/lib.rs

Comment 4

[Chris H-C :chutten]

Weird. After updating that too gives me a clean bill of health.

Ah-ha, this is due to bug 1709496 meaning we should run it against the crate not the entry, e.g. ./mach lint --linter clippy toolkit/components/glean/api/

Huh, apparently I missed TIMING_DISTRIBUTION_MAP, too. Plenty to fix, and then to document.

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1699168 - Fix some clippy nits r?janerik!

Comment 6

[Chris H-C :chutten]

Attachment: Bug 1699168 - Document FOG linting, testing r?janerik!

Depends on D114621

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d49c17230428
Fix some clippy nits r=janerik DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/8e2ea84e4378
Document FOG linting, testing r=janerik DONTBUILD

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d49c17230428
https://hg.mozilla.org/mozilla-central/rev/8e2ea84e4378